Import - add duplicate check on import #12810
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added uniqueness constraint validation during spreadsheet imports to prevent duplicate entries across both simple and composite fields.
- Implemented
spreadsheetImportComputeUnicityRowHookinspreadsheet-import/utils/spreadsheetImportGetUnicityRowHook.tsto validate unique constraints during import - Added
isIncludedInUniqueConstraintfield to composite field configurations insettings/data-model/constants/SettingsCompositeFieldTypeConfigs.tsfor primary identifiers - Enhanced
useOpenObjectRecordsSpreadsheetImportDialogto integrate uniqueness checks through rowHook in import dialog options
3 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
...ont/src/modules/object-record/spreadsheet-import/utils/spreadsheetImportGetUnicityRowHook.ts
Outdated
Show resolved
Hide resolved
...ont/src/modules/object-record/spreadsheet-import/utils/spreadsheetImportGetUnicityRowHook.ts
Outdated
Show resolved
Hide resolved
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:5010 This environment will automatically shut down when the PR is closed or after 5 hours. |
|
|
||
| uniqueConstraintFields.forEach((uniqueConstraint) => { | ||
| const uniqueConstraintRow = uniqueConstraint | ||
| .map((field) => row?.[field] || '') |
There was a problem hiding this comment.
Remark: Unless I'm mistaken we should not be case sensitive here and try to trim most of the fields ?
...ont/src/modules/object-record/spreadsheet-import/utils/spreadsheetImportGetUnicityRowHook.ts
Outdated
Show resolved
Hide resolved
| }); | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
Nitpick: we might wanna display the failing value along the failing field ?
There was a problem hiding this comment.
mmmmh 🤔 not sure it is useful as error message is display when at hover on value
<img width="1217" alt="Screenshot 2025-06-24 at 11 43 03" src="https://github.com/user-attachments/assets/de2bc12e-5e25-484f-a034-f52b0f237a3e" /> Test : - Add duplicate on id or on primaryEmail for people or primaryUrlLink on companies closes twentyhq/core-team-issues#909
Test :
closes twentyhq/core-team-issues#909