Fixed ACTOR advanced filter recent regressions #12813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Fixed advanced filter regressions in ACTOR field type handling, improving filtering functionality in two key areas:
- Added proper filtering of subfield options in
packages/twenty-front/src/modules/object-record/advanced-filter/components/AdvancedFilterSubFieldSelectMenu.tsxto respect theisFilterableproperty from composite field configs - Fixed incorrect component instance ID handling in
packages/twenty-front/src/modules/object-record/advanced-filter/components/AdvancedFilterDropdownFilterInput.tsxforsubFieldNameUsedInDropdownComponentState
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:18831 This environment will automatically shut down when the PR is closed or after 5 hours. |
| @@ -32,7 +32,6 @@ export const AdvancedFilterDropdownFilterInput = ({ | |||
| }: AdvancedFilterDropdownFilterInputProps) => { | |||
| const subFieldNameUsedInDropdown = useRecoilComponentValueV2( | |||
| subFieldNameUsedInDropdownComponentState, | |||
| filterDropdownId, | |||
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 26, 2025
This PR fixes recent regressions on advanced filters for the ACTOR field type. - The new `isFilterable` props on `SETTINGS_COMPOSITE_FIELD_TYPE_CONFIGS` wasn't taken into account for sub field picker in advanced filter. - A wrong component instance id was passed to `subFieldNameUsedInDropdownComponentState`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes recent regressions on advanced filters for the ACTOR field type.
isFilterableprops onSETTINGS_COMPOSITE_FIELD_TYPE_CONFIGSwasn't taken into account for sub field picker in advanced filter.subFieldNameUsedInDropdownComponentState