in connected account, refresh-token can fail with network error #12815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhanced error handling in connected account token refresh operations and messaging import services to properly handle network errors and provider support issues.
- Added
TEMPORARY_NETWORK_ERRORtoConnectedAccountRefreshAccessTokenExceptionCodeto properly categorize network failures during token refresh operations - Replaced
instanceof MessageImportDriverExceptionwith'code' in exceptioncheck to handle plain object errors - Added new
PROVIDER_NOT_SUPPORTEDerror code toMessageImportDriverExceptionCodefor better provider compatibility handling - Improved network error detection in
ConnectedAccountRefreshTokensServiceby handling specific error codes (ENETUNREACH, ETIMEDOUT, etc.) - Enhanced error handling consistency by converting plain object errors to proper exception class instances
6 files reviewed, 3 comments
Edit PR Review Bot Settings | Greptile
| @@ -13,4 +13,5 @@ export enum ConnectedAccountRefreshAccessTokenExceptionCode { | |||
| REFRESH_TOKEN_NOT_FOUND = 'REFRESH_TOKEN_NOT_FOUND', | |||
| REFRESH_ACCESS_TOKEN_FAILED = 'REFRESH_ACCESS_TOKEN_FAILED', | |||
| PROVIDER_NOT_SUPPORTED = 'PROVIDER_NOT_SUPPORTED', | |||
| TEMPORARY_NETWORK_ERROR = 'TEMPORARY_NETWORK_ERROR', | |||
There was a problem hiding this comment.
style: Add a trailing comma after TEMPORARY_NETWORK_ERROR to maintain consistency with enum style and make future additions cleaner
Comment on lines
+97
to
+102
| const networkErrorCodes = [ | ||
| 'ENETUNREACH', | ||
| 'ETIMEDOUT', | ||
| 'ECONNABORTED', | ||
| 'ERR_NETWORK', | ||
| ]; |
There was a problem hiding this comment.
style: Consider moving network error codes to a separate constant or enum for reusability across the codebase
Comment on lines
+106
to
108
| this.logger.log(error?.message); | ||
| this.logger.log(firstErrorCode); | ||
| this.logger.log(error?.errors); |
There was a problem hiding this comment.
style: Use structured logging with error object instead of multiple log calls. Consider: this.logger.log({ message: error?.message, code: firstErrorCode, errors: error?.errors })
📊 API Changes ReportREST API ChangesSummary🔄 Changed Operations (63)
|
guillim
commented
Jun 24, 2025
| @@ -45,7 +45,7 @@ export class MessageImportExceptionHandlerService { | |||
| >, | |||
| workspaceId: string, | |||
| ): Promise<void> { | |||
| if (exception instanceof MessageImportDriverException) { | |||
| if ('code' in exception) { | |||
There was a problem hiding this comment.
most important change to fix the issue
charlesBochet
approved these changes
Jun 24, 2025
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:28372 This environment will automatically shut down when the PR is closed or after 5 hours. |
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 26, 2025
…tyhq#12815) This PR fixes this issue from the connected account refresh token service that is This PR fixes error handling in `handleDriverException` by ensuring that errors resembling `MessageImportDriverException` are correctly detected, even if they are plain objects and not true class instances. This prevents missed exception handling due to failed `instanceof` checks. Was introduced by [this PR](twentyhq#12233) that did not know all provider cases that can occur. Fixes twentyhq#12589
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes this issue from the connected account refresh token service that is
This PR fixes error handling in
handleDriverExceptionby ensuring that errors resemblingMessageImportDriverExceptionare correctly detected, even if they are plain objects and not true class instances. This prevents missed exception handling due to failedinstanceofchecks.Was introduced by this PR that did not know all provider cases that can occur.
Fixes #12589