Improve breaking change CI #12816
Merged
Improve breaking change CI #12816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Optimizes CI workflow to reduce noise by only commenting on breaking API changes, addressing false positives from dynamic example generation with Faker.
- Modified
.github/workflows/ci-breaking-changes.yamlto skip commenting on non-breaking REST Metadata API changes - Improved PR title check syntax using backticks for template literals
- Added specific reporting logic to only generate comments for actual breaking changes
- Prevents redundant comments caused by automatic schema changes from Faker example generation
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
charlesBochet
approved these changes
Jun 24, 2025
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 26, 2025
It used to post a comment if the API schema changed, even if there's no breaking change. I thought this could be OK as an FYI. But it is not since now we generate the examples dynamically with Faker the OpenAPI schema is always different
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to post a comment if the API schema changed, even if there's no breaking change. I thought this could be OK as an FYI. But it is not since now we generate the examples dynamically with Faker the OpenAPI schema is always different