-
Notifications
You must be signed in to change notification settings - Fork 3.6k
i18n - translations #12818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n - translations #12818
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Extensive internationalization update across 27 language files, replacing 'Role name' with 'Untitled Role' as the default text for unnamed roles in the application.
- Files impacted include major languages like Arabic (ar-SA), Chinese (zh-CN/zh-TW), French (fr-FR), German (de-DE), Japanese (ja-JP), consistently marking old 'Role name' translations as obsolete (#~)
- All changes follow standard gettext PO file formatting using message ID 'KmUc2w' for the new 'Untitled Role' string
- All modified translations properly preserve existing language-specific pluralization rules and character sets
- Auto-generated TypeScript files (*.ts) maintain correct @lingui/core Messages type structure with minified JSON strings
60 files reviewed, 8 comments
Edit PR Review Bot Settings | Greptile
msgid "Untitled role" | ||
msgstr "" | ||
|
||
#. js-lingui-id: KmUc2w | ||
#: src/modules/settings/roles/role-settings/components/SettingsRoleSettings.tsx | ||
#: src/modules/settings/roles/role/components/SettingsRoleLabelContainer.tsx | ||
#: src/modules/settings/roles/role/components/SettingsRole.tsx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Adding 'Untitled Role' here requires Norwegian translation to be provided. The msgstr field is empty which will cause the UI to fall back to the msgid.
msgid "Untitled role" | ||
msgstr "" | ||
|
||
#. js-lingui-id: KmUc2w | ||
#: src/modules/settings/roles/role-settings/components/SettingsRoleSettings.tsx | ||
#: src/modules/settings/roles/role/components/SettingsRoleLabelContainer.tsx | ||
#: src/modules/settings/roles/role/components/SettingsRole.tsx | ||
msgid "Untitled Role" | ||
msgstr "" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: New 'Untitled Role' key added but missing Serbian translation
msgid "Untitled role" | |
msgstr "" | |
#. js-lingui-id: KmUc2w | |
#: src/modules/settings/roles/role-settings/components/SettingsRoleSettings.tsx | |
#: src/modules/settings/roles/role/components/SettingsRoleLabelContainer.tsx | |
#: src/modules/settings/roles/role/components/SettingsRole.tsx | |
msgid "Untitled Role" | |
msgstr "" | |
msgid "Untitled role" | |
msgstr "Неименована улога" | |
#. js-lingui-id: KmUc2w | |
#: src/modules/settings/roles/role-settings/components/SettingsRoleSettings.tsx | |
#: src/modules/settings/roles/role/components/SettingsRoleLabelContainer.tsx | |
#: src/modules/settings/roles/role/components/SettingsRole.tsx | |
msgid "Untitled Role" | |
msgstr "Неименована улога" |
|
||
#. js-lingui-id: KmUc2w | ||
#: src/modules/settings/roles/role-settings/components/SettingsRoleSettings.tsx | ||
#: src/modules/settings/roles/role/components/SettingsRoleLabelContainer.tsx | ||
#: src/modules/settings/roles/role/components/SettingsRole.tsx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider adding Arabic translation for 'Untitled Role' instead of leaving it empty
msgid "Untitled role" | ||
msgstr "" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: This string has an empty translation (msgstr) but appears in critical UI elements for role management. Should be translated to maintain a consistent Hebrew interface.
#: src/modules/settings/roles/role-settings/components/SettingsRoleSettings.tsx | ||
#: src/modules/settings/roles/role/components/SettingsRoleLabelContainer.tsx | ||
#: src/modules/settings/roles/role/components/SettingsRole.tsx | ||
msgid "Untitled Role" | ||
msgstr "" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: New string added for role UI but translation is missing. Consider translating as 'תפקיד ללא שם' to match existing UI patterns.
msgid "Untitled role" | ||
msgstr "Untitled role" | ||
|
||
#. js-lingui-id: KmUc2w | ||
#: src/modules/settings/roles/role-settings/components/SettingsRoleSettings.tsx | ||
#: src/modules/settings/roles/role/components/SettingsRoleLabelContainer.tsx | ||
#: src/modules/settings/roles/role/components/SettingsRole.tsx | ||
msgid "Untitled Role" | ||
msgstr "Untitled Role" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Ensure all UI strings use consistent capitalization - 'Untitled role' vs 'Untitled Role' appear in two places
msgid "Untitled role" | ||
msgstr "" | ||
|
||
#. js-lingui-id: KmUc2w | ||
#: src/modules/settings/roles/role-settings/components/SettingsRoleSettings.tsx | ||
#: src/modules/settings/roles/role/components/SettingsRoleLabelContainer.tsx | ||
#: src/modules/settings/roles/role/components/SettingsRole.tsx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: New translation key 'Untitled Role' added but missing Romanian translation. Should provide translation string.
msgid "Untitled role" | |
msgstr "" | |
#. js-lingui-id: KmUc2w | |
#: src/modules/settings/roles/role-settings/components/SettingsRoleSettings.tsx | |
#: src/modules/settings/roles/role/components/SettingsRoleLabelContainer.tsx | |
#: src/modules/settings/roles/role/components/SettingsRole.tsx | |
msgid "Untitled role" | |
msgstr "Rol fără titlu" | |
#. js-lingui-id: KmUc2w | |
#: src/modules/settings/roles/role-settings/components/SettingsRoleSettings.tsx | |
#: src/modules/settings/roles/role/components/SettingsRoleLabelContainer.tsx | |
#: src/modules/settings/roles/role/components/SettingsRole.tsx |
msgid "Untitled role" | ||
msgstr "" | ||
|
||
#. js-lingui-id: KmUc2w | ||
#: src/modules/settings/roles/role-settings/components/SettingsRoleSettings.tsx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider providing a Dutch translation for "Untitled Role", suggested: "Naamloze Rol"
Log
|
Created by Github action --------- Co-authored-by: github-actions <[email protected]>
Created by Github action