Skip to content

i18n - translations #12818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025
Merged

i18n - translations #12818

merged 2 commits into from
Jun 24, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Created by Github action

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Extensive internationalization update across 27 language files, replacing 'Role name' with 'Untitled Role' as the default text for unnamed roles in the application.

  • Files impacted include major languages like Arabic (ar-SA), Chinese (zh-CN/zh-TW), French (fr-FR), German (de-DE), Japanese (ja-JP), consistently marking old 'Role name' translations as obsolete (#~)
  • All changes follow standard gettext PO file formatting using message ID 'KmUc2w' for the new 'Untitled Role' string
  • All modified translations properly preserve existing language-specific pluralization rules and character sets
  • Auto-generated TypeScript files (*.ts) maintain correct @lingui/core Messages type structure with minified JSON strings

60 files reviewed, 8 comments
Edit PR Review Bot Settings | Greptile

Comment on lines 5723 to +5729
msgid "Untitled role"
msgstr ""

#. js-lingui-id: KmUc2w
#: src/modules/settings/roles/role-settings/components/SettingsRoleSettings.tsx
#: src/modules/settings/roles/role/components/SettingsRoleLabelContainer.tsx
#: src/modules/settings/roles/role/components/SettingsRole.tsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Adding 'Untitled Role' here requires Norwegian translation to be provided. The msgstr field is empty which will cause the UI to fall back to the msgid.

Comment on lines 5723 to +5732
msgid "Untitled role"
msgstr ""

#. js-lingui-id: KmUc2w
#: src/modules/settings/roles/role-settings/components/SettingsRoleSettings.tsx
#: src/modules/settings/roles/role/components/SettingsRoleLabelContainer.tsx
#: src/modules/settings/roles/role/components/SettingsRole.tsx
msgid "Untitled Role"
msgstr ""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: New 'Untitled Role' key added but missing Serbian translation

Suggested change
msgid "Untitled role"
msgstr ""
#. js-lingui-id: KmUc2w
#: src/modules/settings/roles/role-settings/components/SettingsRoleSettings.tsx
#: src/modules/settings/roles/role/components/SettingsRoleLabelContainer.tsx
#: src/modules/settings/roles/role/components/SettingsRole.tsx
msgid "Untitled Role"
msgstr ""
msgid "Untitled role"
msgstr "Неименована улога"
#. js-lingui-id: KmUc2w
#: src/modules/settings/roles/role-settings/components/SettingsRoleSettings.tsx
#: src/modules/settings/roles/role/components/SettingsRoleLabelContainer.tsx
#: src/modules/settings/roles/role/components/SettingsRole.tsx
msgid "Untitled Role"
msgstr "Неименована улога"

Comment on lines 5725 to +5729

#. js-lingui-id: KmUc2w
#: src/modules/settings/roles/role-settings/components/SettingsRoleSettings.tsx
#: src/modules/settings/roles/role/components/SettingsRoleLabelContainer.tsx
#: src/modules/settings/roles/role/components/SettingsRole.tsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider adding Arabic translation for 'Untitled Role' instead of leaving it empty

Comment on lines 5723 to 5725
msgid "Untitled role"
msgstr ""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: This string has an empty translation (msgstr) but appears in critical UI elements for role management. Should be translated to maintain a consistent Hebrew interface.

Comment on lines +5727 to +5732
#: src/modules/settings/roles/role-settings/components/SettingsRoleSettings.tsx
#: src/modules/settings/roles/role/components/SettingsRoleLabelContainer.tsx
#: src/modules/settings/roles/role/components/SettingsRole.tsx
msgid "Untitled Role"
msgstr ""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: New string added for role UI but translation is missing. Consider translating as 'תפקיד ללא שם' to match existing UI patterns.

Comment on lines 5718 to +5726
msgid "Untitled role"
msgstr "Untitled role"

#. js-lingui-id: KmUc2w
#: src/modules/settings/roles/role-settings/components/SettingsRoleSettings.tsx
#: src/modules/settings/roles/role/components/SettingsRoleLabelContainer.tsx
#: src/modules/settings/roles/role/components/SettingsRole.tsx
msgid "Untitled Role"
msgstr "Untitled Role"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Ensure all UI strings use consistent capitalization - 'Untitled role' vs 'Untitled Role' appear in two places

Comment on lines 5723 to +5729
msgid "Untitled role"
msgstr ""

#. js-lingui-id: KmUc2w
#: src/modules/settings/roles/role-settings/components/SettingsRoleSettings.tsx
#: src/modules/settings/roles/role/components/SettingsRoleLabelContainer.tsx
#: src/modules/settings/roles/role/components/SettingsRole.tsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: New translation key 'Untitled Role' added but missing Romanian translation. Should provide translation string.

Suggested change
msgid "Untitled role"
msgstr ""
#. js-lingui-id: KmUc2w
#: src/modules/settings/roles/role-settings/components/SettingsRoleSettings.tsx
#: src/modules/settings/roles/role/components/SettingsRoleLabelContainer.tsx
#: src/modules/settings/roles/role/components/SettingsRole.tsx
msgid "Untitled role"
msgstr "Rol fără titlu"
#. js-lingui-id: KmUc2w
#: src/modules/settings/roles/role-settings/components/SettingsRoleSettings.tsx
#: src/modules/settings/roles/role/components/SettingsRoleLabelContainer.tsx
#: src/modules/settings/roles/role/components/SettingsRole.tsx

Comment on lines 5723 to +5727
msgid "Untitled role"
msgstr ""

#. js-lingui-id: KmUc2w
#: src/modules/settings/roles/role-settings/components/SettingsRoleSettings.tsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider providing a Dutch translation for "Untitled Role", suggested: "Naamloze Rol"

@FelixMalfait FelixMalfait merged commit 480f135 into main Jun 24, 2025
3 checks passed
@FelixMalfait FelixMalfait deleted the i18n branch June 24, 2025 12:22
Copy link
Contributor Author

Fails
🚫

node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5738:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5719:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:4609:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)�[39m
�[90m    at async consumeBody (node:internal/deps/undici/undici:5728:7)�[39m
danger-results://tmp/danger-results-d9bcdd99.json

Generated by 🚫 dangerJS against e26e66b

abdulrahmancodes pushed a commit to abdulrahmancodes/twenty that referenced this pull request Jun 26, 2025
Created by Github action

---------

Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant