-
Notifications
You must be signed in to change notification settings - Fork 3.6k
i18n - translations #12820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n - translations #12820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Comprehensive internationalization update across all language files to standardize role-related translations, focusing on deprecating 'Untitled Role' and activating 'Role name' strings.
- Systematically updated 27 locale files including major languages (en, fr-FR, de-DE, zh-CN) to reflect role terminology changes
- All updates follow consistent pattern: uncommenting 'Role name' while deprecating 'Untitled Role' with #~ prefix
- Translation strings remain empty (msgstr "") in many languages, indicating translations still needed
- Changes properly maintain PO file structure with metadata and msgid/msgstr pairs
- Special consideration needed for RTL languages like ar-SA and he-IL in role management UI
31 files reviewed, 3 comments
Edit PR Review Bot Settings | Greptile
#. js-lingui-id: iSfzXo | ||
#: src/modules/settings/roles/role-settings/components/SettingsRoleSettings.tsx | ||
#: src/modules/settings/roles/role/components/SettingsRoleLabelContainer.tsx | ||
#~ msgid "Role name" | ||
#~ msgstr "" | ||
msgid "Role name" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Missing translation for 'Role name' key that was just activated. Should have a Korean translation in msgstr
#. js-lingui-id: iSfzXo | ||
#: src/modules/settings/roles/role-settings/components/SettingsRoleSettings.tsx | ||
#: src/modules/settings/roles/role/components/SettingsRoleLabelContainer.tsx | ||
#~ msgid "Role name" | ||
#~ msgstr "" | ||
msgid "Role name" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Inconsistency: The role name string is activated but has an empty translation (msgstr ""). This will result in missing translations for Czech users. Translation should be provided.
msgid "Role name" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider adding a Chinese translation for 'Role name' instead of leaving it empty, as this is a user-facing string.
msgid "Role name" | |
msgstr "" | |
msgid "Role name" | |
msgstr "角色名称" |
Log
|
Created by Github action Co-authored-by: github-actions <[email protected]>
Created by Github action