Skip to content

i18n - translations #12820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

i18n - translations #12820

merged 1 commit into from
Jun 24, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Created by Github action

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Comprehensive internationalization update across all language files to standardize role-related translations, focusing on deprecating 'Untitled Role' and activating 'Role name' strings.

  • Systematically updated 27 locale files including major languages (en, fr-FR, de-DE, zh-CN) to reflect role terminology changes
  • All updates follow consistent pattern: uncommenting 'Role name' while deprecating 'Untitled Role' with #~ prefix
  • Translation strings remain empty (msgstr "") in many languages, indicating translations still needed
  • Changes properly maintain PO file structure with metadata and msgid/msgstr pairs
  • Special consideration needed for RTL languages like ar-SA and he-IL in role management UI

31 files reviewed, 3 comments
Edit PR Review Bot Settings | Greptile

Comment on lines 4604 to +4607
#. js-lingui-id: iSfzXo
#: src/modules/settings/roles/role-settings/components/SettingsRoleSettings.tsx
#: src/modules/settings/roles/role/components/SettingsRoleLabelContainer.tsx
#~ msgid "Role name"
#~ msgstr ""
msgid "Role name"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing translation for 'Role name' key that was just activated. Should have a Korean translation in msgstr

Comment on lines 4604 to +4607
#. js-lingui-id: iSfzXo
#: src/modules/settings/roles/role-settings/components/SettingsRoleSettings.tsx
#: src/modules/settings/roles/role/components/SettingsRoleLabelContainer.tsx
#~ msgid "Role name"
#~ msgstr ""
msgid "Role name"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Inconsistency: The role name string is activated but has an empty translation (msgstr ""). This will result in missing translations for Czech users. Translation should be provided.

Comment on lines +4607 to +4608
msgid "Role name"
msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider adding a Chinese translation for 'Role name' instead of leaving it empty, as this is a user-facing string.

Suggested change
msgid "Role name"
msgstr ""
msgid "Role name"
msgstr "角色名称"

@FelixMalfait FelixMalfait merged commit b4f7b54 into main Jun 24, 2025
3 checks passed
@FelixMalfait FelixMalfait deleted the i18n branch June 24, 2025 12:43
Copy link
Contributor Author

Fails
🚫

node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5738:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5719:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:4609:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)�[39m
�[90m    at async consumeBody (node:internal/deps/undici/undici:5728:7)�[39m
danger-results://tmp/danger-results-17c9505d.json

Generated by 🚫 dangerJS against a74b196

abdulrahmancodes pushed a commit to abdulrahmancodes/twenty that referenced this pull request Jun 26, 2025
Created by Github action

Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant