Fix phone deletion #12821
Merged
Fix phone deletion #12821
+25
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhanced phone number validation in the server's record transformer by adding empty string checks.
- Added
isNonEmptyStringvalidation intransform-phones-value.util.tsto prevent processing of empty phone numbers [1553f120-8908-4962-bc22-796896959d06] - Re-organized imports for better code readability
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
prastoin
reviewed
Jun 24, 2025
...wenty-server/src/engine/core-modules/record-transformer/utils/transform-phones-value.util.ts
Show resolved
Hide resolved
prastoin
approved these changes
Jun 24, 2025
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:10159 This environment will automatically shut down when the PR is closed or after 5 hours. |
prastoin
approved these changes
Jun 24, 2025
| @@ -306,7 +323,7 @@ const FAILING_TEST_CASES: EachTestingContext<CreatePhoneFieldMetadataTestCase>[] | |||
| describe('Phone field metadata tests suite', () => { | |||
| let createdObjectMetadataId: string; | |||
|
|
|||
| beforeEach(async () => { | |||
| beforeAll(async () => { | |||
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes twentyhq/core-team-issues#1124