Improve onboarding experience #12824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhanced workspace creation UI with improved feedback and loading states during the onboarding process.
- Added proper loading state management for workspace creation with clear visual progress indicators and user feedback
- Implemented Recoil state management for consistent workspace data handling across components
- Added Logo component with adaptive sizing for workspace branding during creation flow
- Improved error handling with user-friendly error messages via snackbar notifications
- Made loading container responsive by removing fixed height constraints
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Comment on lines
+158
to
+161
| isNonEmptyString(currentWorkspace?.logo) | ||
| ? currentWorkspace?.logo | ||
| : undefined | ||
| } |
There was a problem hiding this comment.
style: Optional chaining is already used with '?.logo', making the ternary check redundant. Can simplify to 'currentWorkspace?.logo'
Suggested change
| isNonEmptyString(currentWorkspace?.logo) | |
| ? currentWorkspace?.logo | |
| : undefined | |
| } | |
| currentWorkspace?.logo |
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:15490 This environment will automatically shut down when the PR is closed or after 5 hours. |
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enregistrement.de.l.ecran.2025-06-24.a.14.57.51.mov