Skip to content

i18n - translations #12828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2025
Merged

i18n - translations #12828

merged 2 commits into from
Jun 24, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Created by Github action

greptile-apps[bot]
greptile-apps bot reviewed Jun 24, 2025
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Comprehensive internationalization update across multiple language files, adding new translations for workspace creation flow and improving loading state feedback.

  • Updated all locale files to replace technical term 'schema' with user-friendly 'data model' in UI messages
  • Added ellipsis (...) to progress indicators across all languages for better loading state feedback (e.g., 'Creating your data model...')
  • Several key files (tr-TR.po, vi-VN.po, cs-CZ.po) contain untranslated strings needing attention
  • Full implementation of right-to-left (RTL) support in Arabic (ar-SA) translations
  • Consistent implementation of pluralization rules across language files, particularly visible in Russian (ru-RU) and Polish (pl-PL) translations

60 files reviewed, 8 comments
Edit PR Review Bot Settings | Greptile

packages/twenty-front/src/locales/no-NO.po
Comment on lines 1492 to +1497

#. js-lingui-id: fR16ki
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Creating your data model..."
msgstr ""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing translation for new key 'Creating your data model...' which should be added to maintain full Norwegian localization

Suggested change
#. js-lingui-id: fR16ki
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Creating your data model..."
msgstr ""
#. js-lingui-id: fR16ki
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Creating your data model..."
msgstr "Oppretter datamodellen din..."

packages/twenty-front/src/locales/de-DE.po
@@ -4327,7 +4337,12 @@ msgstr "Portugiesisch - Portugal"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Missing German translation for new progress indicator string 'Prefilling your workspace data...'

packages/twenty-front/src/locales/de-DE.po
@@ -5017,7 +5032,12 @@ msgstr "Subdomainnamen festlegen"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Missing German translation for new progress indicator string 'Setting up your database...'

packages/twenty-front/src/locales/zh-CN.po
Comment on lines 1490 to 1507
#~ msgid "Created"
#~ msgstr "已创建"

#. js-lingui-id: fR16ki
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Creating your data model..."
msgstr ""

#. js-lingui-id: TlL0Pl
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Creating your schema"
#~ msgid "Creating your schema"
#~ msgstr ""

#. js-lingui-id: YO4SdK
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Creating your workspace"
msgstr ""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Several strings related to workspace creation are missing translations (empty msgstr). These should be translated to ensure complete Chinese localization: 'Creating your data model...', 'Creating your workspace', etc.

packages/twenty-front/src/locales/zh-CN.po
@@ -5017,7 +5032,12 @@ msgstr "设置您的子域名"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Translation for 'Setting up your database...' is missing but should follow the same pattern as other progress indicators in the UI

packages/twenty-front/src/locales/ja-JP.po
Comment on lines +1493 to +1497
#. js-lingui-id: fR16ki
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Creating your data model..."
msgstr ""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing Japanese translation for 'Creating your data model...' which is a new user-facing string that should be translated

Suggested change
#. js-lingui-id: fR16ki
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Creating your data model..."
msgstr ""
#. js-lingui-id: fR16ki
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Creating your data model..."
msgstr "データモデルを作成中..."

packages/twenty-front/src/locales/ja-JP.po
Comment on lines 4337 to +4341

#. js-lingui-id: /IZFIg
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Prefilling your workspace data"
#~ msgid "Prefilling your workspace data"
#~ msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing Japanese translation for 'Prefilling your workspace data...' which is another user-facing string that should be translated

Suggested change
#. js-lingui-id: /IZFIg
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Prefilling your workspace data"
#~ msgid "Prefilling your workspace data"
#~ msgstr ""
#. js-lingui-id: /v6Rp9
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Prefilling your workspace data..."
msgstr "ワークスペースデータを事前入力中..."

packages/twenty-front/src/locales/ja-JP.po
Comment on lines 5032 to +5036

#. js-lingui-id: oG3fDz
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Setting up your database"
#~ msgid "Setting up your database"
#~ msgstr ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Missing Japanese translation for 'Setting up your database...' which is an important user-facing status message that should be translated

Suggested change
#. js-lingui-id: oG3fDz
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Setting up your database"
#~ msgid "Setting up your database"
#~ msgstr ""
#. js-lingui-id: dQsqpC
#: src/pages/onboarding/CreateWorkspace.tsx
msgid "Setting up your database..."
msgstr "データベースを設定中..."

@charlesBochet charlesBochet merged commit 251a19b into main Jun 24, 2025
3 checks passed
@charlesBochet charlesBochet deleted the i18n branch June 24, 2025 13:15
@github-actions GitHub Actions
Copy link
Contributor Author

Fails
🚫

node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5738:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5719:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:4609:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)�[39m
�[90m    at async consumeBody (node:internal/deps/undici/undici:5728:7)�[39m
danger-results://tmp/danger-results-50b168c2.json

Generated by 🚫 dangerJS against 4978586

abdulrahmancodes pushed a commit to abdulrahmancodes/twenty that referenced this pull request Jun 26, 2025
@github-actions @abdulrahmancodes
i18n - translations (twentyhq#12828)
7cba5e1 
Created by Github action

---------

Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charlesBochet