Add metrics to workflows #12829
Merged
Add metrics to workflows #12829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thomtrp
commented
Jun 24, 2025
thomtrp
commented
- ensure each trigger is working properly
- check throttle does not happen too often
- keep an eye on the completed/failed proportion
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added comprehensive metrics tracking to the workflow system to monitor execution health and performance.
- Implemented workflow completion metrics in
packages/twenty-server/src/modules/workflow/workflow-runner/workflow-run/workflow-run.workspace-service.tsto track success/failure rates - Added trigger-specific metrics in
packages/twenty-server/src/modules/workflow/workflow-runner/jobs/run-workflow.job.tsfor DATABASE_EVENT, CRON, WEBHOOK, and MANUAL triggers - Integrated throttling metrics to monitor rate limiting occurrences and prevent excessive executions
- Defined new metric keys in
engine/core-modules/metrics/types/metrics-keys.type.tsfor standardized tracking across the system - Added MetricsModule imports across workflow modules following NestJS architectural patterns
5 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
packages/twenty-server/src/modules/workflow/workflow-runner/jobs/run-workflow.job.ts
Outdated
Show resolved
Hide resolved
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:35818 This environment will automatically shut down when the PR is closed or after 5 hours. |
thomtrp
force-pushed
the
tt-add-metrics-to-workflow-run
branch
from
24db651 to
7b027f5
Compare
charlesBochet
approved these changes
Jun 24, 2025
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 26, 2025
- ensure each trigger is working properly - check throttle does not happen too often - keep an eye on the completed/failed proportion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.