Add graphql queries error codes metrics #12833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added GraphQL query error metrics tracking through MetricsService integration with the existing useGraphQLErrorHandlerHook, enabling monitoring of operation outcomes using HTTP status codes.
- Implemented error code metrics tracking in
core-modules/graphql/hooks/use-graphql-error-handler.hook.tsby mapping GraphQL errors to HTTP status codes (200, 400, 401, etc.) - Added six new metric keys in
metrics-keys.type.tsfollowing existing naming patterns for tracking different response codes - Modified
MetricsServiceto handle optional eventIds, improving flexibility in metrics collection - Integrated MetricsModule across the application through changes in app.module.ts and metadata-related modules
- Maintained existing error handling while adding comprehensive metrics collection for system observability
7 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Comment on lines
+40
to
41
| metricsService: metricsService, | ||
| exceptionHandlerService, |
There was a problem hiding this comment.
style: metricsService should be placed after exceptionHandlerService to maintain consistent property ordering with the function parameters
charlesBochet
approved these changes
Jun 24, 2025
charlesBochet
approved these changes
Jun 24, 2025
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:65356 This environment will automatically shut down when the PR is closed or after 5 hours. |
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 26, 2025
## Context Added to the existing useGraphQLErrorHandlerHook yoga hook to increment metrics after all query executions based on their error codes. I originally wanted to create a new useMetrics hook but most of the error handling was done in useGraphQLErrorHandlerHook so we decided to keep it there for now. <img width="1310" alt="Screenshot 2025-06-24 at 15 58 26" src="https://github.com/user-attachments/assets/498d3754-851a-4051-a5c2-23ac8253aa6a" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Added to the existing useGraphQLErrorHandlerHook yoga hook to increment metrics after all query executions based on their error codes. I originally wanted to create a new useMetrics hook but most of the error handling was done in useGraphQLErrorHandlerHook so we decided to keep it there for now.