feat(captcha): improve telemetry on captcha error #12836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhanced error telemetry across captcha validation system by standardizing error messages and adding detailed metrics tracking.
- Standardized error messages in both
TurnstileDriverandGoogleRecaptchaDriverfrom 'Captcha Error' to 'unknown-error' for better error tracking - Enhanced
MetricsServiceinpackages/twenty-server/src/engine/core-modules/metrics/metrics.service.tsto support attributes in telemetry counters - Added error attributes to metrics in
CaptchaGuardfor improved failure tracking and debugging - Aligned with OpenTelemetry standards for better integration with monitoring systems
4 files reviewed, 3 comments
Edit PR Review Bot Settings | Greptile
packages/twenty-server/src/engine/core-modules/captcha/drivers/google-recaptcha.driver.ts
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/metrics/metrics.service.ts
Show resolved
Hide resolved
Comment on lines
34
to
36
| ...(!responseData.success && { | ||
| error: responseData['error-codes']?.[0] ?? 'Captcha Error', | ||
| error: responseData['error-codes']?.[0] ?? 'unknown-error', | ||
| }), |
There was a problem hiding this comment.
style: Consider adding a constant for 'unknown-error' to maintain consistency and avoid magic strings
| shouldStoreInCache = true, | ||
| }: { | ||
| key: MetricsKeys; | ||
| eventIds: string[]; | ||
| attributes?: Attributes; |
There was a problem hiding this comment.
how does this work? can a counter have attributes? how does this aggregates?
…error-telemetry # Conflicts: # packages/twenty-server/src/engine/core-modules/metrics/metrics.service.ts
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:6942 This environment will automatically shut down when the PR is closed or after 5 hours. |
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.