Force readonly for deletedAt field #12840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijreilly
approved these changes
Jun 24, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Forces readonly mode for deletedAt datepicker field to ensure proper handling of record deletion through the UI trash icon instead of direct field modification.
- Added readonly condition in
packages/twenty-front/src/modules/object-record/record-show/record-detail-section/components/RecordDetailRelationRecordsListItem.tsxto prevent direct modification of deletedAt field - Directs users to use the trash icon for soft deleting records instead of manually setting deletedAt date
- Implements safeguard against potential permission handling issues with deletedAt field modifications
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Comment on lines
310
to
311
| isReadOnly: | ||
| fieldMetadataItem.name === 'deletedAt' || isFieldReadOnly, |
There was a problem hiding this comment.
style: Consider extracting special field names like 'deletedAt' into a constant or enum to avoid magic strings and improve maintainability
There was a problem hiding this comment.
modify isFieldValueReadOnly
charlesBochet
approved these changes
Jun 24, 2025
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:17707 This environment will automatically shut down when the PR is closed or after 5 hours. |
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 26, 2025
Fixes twentyhq#12839 ## Context We now force readonly mode for deletedAt datepicker as permissions don't handle well this use case. The frontend should call softDelete endpoint in this case. For a user, they should select the record and click on the trash icon instead <img width="467" alt="Screenshot 2025-06-24 at 17 30 03" src="https://github.com/user-attachments/assets/0a8a0709-305b-440f-91c2-d5e3f23ca213" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12839
Context
We now force readonly mode for deletedAt datepicker as permissions don't handle well this use case. The frontend should call softDelete endpoint in this case. For a user, they should select the record and click on the trash icon instead