Skip to content

Fix recordTableCells being displayed several time on record group tables #12843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

charlesBochet
Copy link
Member

@charlesBochet charlesBochet commented Jun 24, 2025

As per title!

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Fixed a performance issue in record group tables by preventing duplicate rendering of RecordTableCellPortals.

  • Modified RecordTableRecordGroupsBody.tsx to only render RecordTableCellPortals for the first group (index === 0), eliminating redundant portal instances and potential visual artifacts
  • This change improves rendering efficiency in grouped table views by ensuring each cell portal appears exactly once

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

@charlesBochet charlesBochet merged commit 77f0ed2 into main Jun 24, 2025
53 of 55 checks passed
@charlesBochet charlesBochet deleted the fix-opacity-on-group-by branch June 24, 2025 15:29
Copy link
Contributor

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:60345

This environment will automatically shut down when the PR is closed or after 5 hours.

abdulrahmancodes pushed a commit to abdulrahmancodes/twenty that referenced this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant