fix confirmation modal on subdomain settings

[ehconitin]

before -

2025-06-24.20-37-10.mov

after -

2025-06-24.20-54-32.mov

[greptile-apps]

PR Summary

Fixed confirmation modal behavior in workspace subdomain settings to properly handle conflict scenarios and form submission structure.

• Moved ConfirmationModal component outside the form element in packages/twenty-front/src/pages/settings/workspace/SettingsDomain.tsx to prevent form submission issues
• Added closeModal from useModal hook to properly dismiss the modal when subdomain conflicts occur
• Improved error handling flow by ensuring modal closes when domain validation fails

_{1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile}

[greptile-apps]

style: Consider using early return in onConfirmClick to avoid using && operator for conditional execution. Better pattern would be:

Suggested change

	<ConfirmationModal
	modalId={SUBDOMAIN_CHANGE_CONFIRMATION_MODAL_ID}
	title={t`Change subdomain?`}
	subtitle={t`You're about to change your workspace subdomain. This action will log out all users.`}
	onConfirmClick={() => {
	const values = form.getValues();
	currentWorkspace &&
	updateSubdomain(values.subdomain, currentWorkspace);
	}}
	/>
	onConfirmClick={() => {
	const values = form.getValues();
	if (!currentWorkspace) return;
	updateSubdomain(values.subdomain, currentWorkspace);
	}}

[AMoreaux]

LGTM 👌

[github-actions]

Thanks @ehconitin for your contribution!
This marks your 154th PR on the repo. You're top 1% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

[github-actions]

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:11015

This environment will automatically shut down when the PR is closed or after 5 hours.