Fix resolver-validation validation snake trap #12850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhanced GraphQL resolver validation pipe to prevent validation errors from causing silent failures, focusing on safer error handling and improved validation flow.
- Added
safeClassValidatorValidateWrapperfunction inresolver-validation.pipe.tsto handle validation errors gracefully instead of silently failing - Streamlined validation flow by removing nested try-catch blocks for better error tracking
- Fixed potential snake trap where validation errors were being swallowed by returning original values without proper error handling
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
packages/twenty-server/src/engine/core-modules/graphql/pipes/resolver-validation.pipe.ts
Outdated
Show resolved
Hide resolved
Weiko
reviewed
Jun 24, 2025
packages/twenty-server/src/engine/core-modules/graphql/pipes/resolver-validation.pipe.ts
Show resolved
Hide resolved
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:60122 This environment will automatically shut down when the PR is closed or after 5 hours. |
prastoin
changed the title
resolver-validation validation snake trap
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 26, 2025
# Introduction This PR might have a lot of impact on tested validation Avoid catching programmatically thrown error --------- Co-authored-by: Charles Bochet <[email protected]>
AMoreaux
added a commit
that referenced
this pull request
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR might have a lot of impact on tested validation
Avoid catching programmatically thrown error