Prevent index updates during sync metadata #12856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Introduces a temporary fix to prevent unintended index column updates during metadata synchronization by skipping differences where path length > 1 in the workspace index comparator.
- Modified
workspace-index.comparator.tsto conditionally skip nested path updates for existing indexes - Added TODO comment indicating need for proper handling of index updates in future
- Change preserves index creation and deletion operations while only restricting updates
- This is a temporary workaround to prevent potential issues during synchronization
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
| @@ -63,6 +63,11 @@ export class WorkspaceIndexComparator { | |||
| ); | |||
|
|
|||
| for (const difference of indexesDifferences) { | |||
| // TODO: This code prevent index updates, we need to handle them | |||
| if (difference.path.length > 1) { | |||
There was a problem hiding this comment.
style: Add a more detailed comment explaining why path.length > 1 indicates an index update, and what specific scenarios this prevents
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:60928 This environment will automatically shut down when the PR is closed or after 5 hours. |
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title