chore: Update to junit5 and doc upgrades #856
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiwarishubham635
requested changes
May 26, 2025
| @@ -30,18 +30,18 @@ public void singleArgConstructorShouldPreserveMessage() { | |||
| @Test | |||
| public void twoArgConstructorShouldPreserveMessageAndCause() { | |||
| ApiException error = new ApiException(anyMessage, anyCause); | |||
| assertEquals("Message", anyMessage, error.getMessage()); | |||
| assertSame("Cause", anyCause, error.getCause()); | |||
| assertEquals(anyMessage, error.getMessage()); | |||
There was a problem hiding this comment.
Why are we removing the strings in these assert functions while they are unchanged over here?
| @@ -30,29 +33,29 @@ public void setUp() { | |||
|
|
|||
| @Test | |||
| public void testValidate() { | |||
| Assert.assertTrue("Request does not match provided signature", validator.validate(url, params, signature)); | |||
| assertTrue(validator.validate(url, params, signature)); | |||
There was a problem hiding this comment.
Do we need to remove these strings too?
There was a problem hiding this comment.
If yes, what are we checking that the validate() will return? Just any non-false response?
| .elevenlabsTextNormalization("elevenlabs_text_normalization") | ||
| .interruptSensitivity("interrupt_sensitivity") | ||
| .debug("debug") | ||
| .welcomeGreetingInterruptible("true") |
There was a problem hiding this comment.
Why are the changes made here to just check a true response and not exact string matching?
| .elevenlabsTextNormalization("elevenlabs_text_normalization") | ||
| .interruptSensitivity("interrupt_sensitivity") | ||
| .debug("debug") | ||
| .welcomeGreetingInterruptible("true") |
|
Cluster tests are failing, can you recheck? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Upgrade to junit5
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.