Skip to content

Enhancement: [rule-tester] remove spurious dependency on @eslint/eslintrc #9785

Closed
@jakebailey

Description

@jakebailey

Before You File a Proposal Please Confirm You Have Done The Following...

Relevant Package

rule-tester

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Description

In microsoft/TypeScript#59518 I was updating TS to use ESLint v9 and typescript-eslint v8. I noticed in the lockfile that @eslint/eslintrc was present even though I didn't depend on it. npm why @eslint/eslintrc gave me:

@eslint/[email protected] dev
node_modules/@eslint/eslintrc
  peer @eslint/eslintrc@">=2" from @typescript-eslint/[email protected]
  node_modules/@typescript-eslint/rule-tester
    dev @typescript-eslint/rule-tester@"^8.1.0" from the root project
  @eslint/eslintrc@"^3.1.0" from [email protected]
  node_modules/eslint
    dev eslint@"^9.9.0" from the root project

My reading of this is that eslint itself still depends on this, so it can't go away, but I didn't realize this at the time and thought @typescript-eslint/rule-tester may be the only reason we had it. Searching though the package, I noticed that it never uses @eslint/eslintrc, so the dep could actually just be removed without any changes.

Filing an issue since I think you require one before sending a PR.

Additional Info

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuelocked due to agePlease open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.package: rule-testerIssues related to the @typescript-eslint/rule-tester packagerepo maintenancethings to do with maintenance of the repo, and not with code/docs

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions