chore: migrate to pnpm #11248

xaos7991 · 2025-05-27T17:52:42Z

PR Checklist

Addresses an existing open issue: fixes Repo: Migrate from yarn to pnpm #10891
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

refactor: removed .yarn folder fix: changed overrides approach feat: changed references

Replacing variables

Migrate scripts to pnpm and replaced yarn reference

Replaced yarn reference with pnpm

Added rule schema types

Fixed types

Launching app pnpm

Resolved problems with babel types

docs: updated comments to reflect pnpm usage instead of yarn

# Conflicts: # package.json # packages/eslint-plugin/package.json # packages/type-utils/package.json # packages/website/package.json # yarn.lock

fix: resolved conflicts fix: corrected the version

# Conflicts: # CONTRIBUTORS.md # packages/eslint-plugin/package.json # packages/type-utils/package.json # tools/scripts/generate-contributors.mts # yarn.lock

# Conflicts: # packages/eslint-plugin/package.json # packages/type-utils/package.json # yarn.lock

# Conflicts: # knip.ts # nx.json # packages/ast-spec/package.json # packages/eslint-plugin-internal/package.json # packages/eslint-plugin/package.json # packages/integration-tests/package.json # packages/parser/package.json # packages/rule-schema-to-typescript-types/package.json # packages/rule-tester/package.json # packages/scope-manager/package.json # packages/type-utils/package.json # packages/types/package.json # packages/typescript-eslint/package.json # packages/typescript-estree/package.json # packages/utils/package.json # packages/visitor-keys/package.json # yarn.lock

xaos7991 · 2025-07-01T17:41:57Z

Hi @JoshuaKGoldberg, @JamesHenry, @bradzacher, @kirkwaiblinger, and the rest of the team! 👋

First of all, thank you for all the work you do maintaining this project — it’s a huge help to the community, and I really appreciate the time and care you put into it.

I was just wondering if there’s any chance a maintainer could take a look at this PR. I understand you're all busy, but since it hasn’t received a review from a maintainer yet, I’d be happy, along with @Jester175, to revise or adjust anything needed once there’s some feedback.

Thanks again!

# Conflicts: # tools/scripts/generate-sponsors.mts # yarn.lock

JamesHenry

Thanks for this @xaos7991!

Please kindly take a look at all the inline comments.

Additionally:

The changes to the dependency and task graphs of the workspace through this change of package manager are unexpected and make me nervous that scope creep has occurred. Can we achieve this change of package manager without changing the relationships in the repo please? If they need to be changed for correctness let's please discuss and potentially address in a follow up (or pre-requisite PR)
I am not familiar enough with -w exec so I will need to check out the PR to play with that in all the subpackages, which I will do when other tasks have been addressed.
I will push a commit to change the release setup once all other TODOs are addressed and the PR is green again

JamesHenry · 2025-07-08T11:29:48Z

.github/actions/prepare-install/action.yml

@@ -30,50 +30,24 @@ runs:
      working-directory: ${{ inputs.working-directory }}
      run: echo ${{ github.ref }}

+    - uses: actions/checkout@v4


Why did you add another checkout here?

I probably didn't notice that extra checkout. I've removed it now based on your suggestion.

JamesHenry · 2025-07-08T11:31:28Z

.github/workflows/ci.yml

@@ -129,7 +129,7 @@ jobs:
        uses: ./.github/actions/prepare-build

      - name: Run Check
-        run: yarn ${{ matrix.lint-task }}
+        run: pnpm ${{ matrix.lint-task }}


Missing run for consistency with your other ones

Hi! 👋
Thanks a lot for the review🙌

Just a quick note on this:
- name: Run Check
run: pnpm ${{ matrix.lint-task }}

You're right that for consistency with the other commands, it might make sense to use run: pnpm run .... However, in our case, we have one task in the matrix (knip) that directly runs a binary (i.e. knip) and doesn't currently have a corresponding script entry in package.json.

To use pnpm run knip, we'd need to define a script like "knip": "knip" in package.json. We chose to call the binary directly here to avoid extra script declarations.

Please correct me if I’m mistaken, but that was the reasoning behind the current setup. Happy to align if you think we should change it! 😊

JamesHenry · 2025-07-08T11:33:14Z

.github/workflows/nx-migrate.yml

pnpm needs to be installed into this workflow for it to continue to work, it should be done without running an install.

- uses: pnpm/action-setup@v4 if: ${{ steps.nrwl-workspace-package-check.outputs.was-changed == 'true' }} name: Install pnpm with: run_install: false

You can cross-reference with my other repo which already uses pnpm here: https://github.com/angular-eslint/angular-eslint/blob/main/.github/workflows/nx-migrate.yml

JamesHenry · 2025-07-08T11:35:12Z

.github/workflows/nx-migrate.yml


-          YARN_ENABLE_IMMUTABLE_INSTALLS=false yarn install
+          pnpm install


The install should allow modifications:

# We need to expect lock file changes to be applicable pnpm install --ignore-scripts --frozen-lockfile=false

JamesHenry · 2025-07-08T11:35:25Z

.github/workflows/nx-migrate.yml


          # Sometimes Nx can require config formatting changes after a migrate command
-          YARN_ENABLE_IMMUTABLE_INSTALLS=false yarn install
-          yarn nx format
+          pnpm install


JamesHenry · 2025-07-08T11:40:49Z

nx.json

@@ -68,9 +68,6 @@
      {
        "runtime": "node -v"
      },
-      {
-        "runtime": "yarn -v"


Replace with pnpm -v, don't remove

JamesHenry · 2025-07-08T11:44:50Z

packages/integration-tests/fixtures/eslint-v8/package.json

@@ -1,5 +1,6 @@
 {
  "devDependencies": {
-    "eslint": "8.57.0"
+    "eslint": "8.57.0",
+    "@eslint/js": "latest"


This is a different major version to the eslint package, this feels wrong...

JamesHenry · 2025-07-08T11:45:34Z

packages/integration-tests/tools/integration-test-base.ts

@@ -35,7 +35,7 @@ export function eslintIntegrationTest(
    let stderr = '';
    try {
      await execFile(
-        'yarn',
+        'pnpm',


Missing usage of run for consistency

JamesHenry · 2025-07-08T11:45:38Z

packages/integration-tests/tools/integration-test-base.ts

@@ -94,7 +94,7 @@ export function typescriptIntegrationTest(
 ): void {
  integrationTest(testName, testFilename, async testFolder => {
    const [result] = await Promise.allSettled([
-      execFile('yarn', ['tsc', '--noEmit', '--skipLibCheck', ...tscArgs], {
+      execFile('pnpm', ['tsc', '--noEmit', '--skipLibCheck', ...tscArgs], {


Missing usage of run for consistency

JamesHenry · 2025-07-08T11:50:46Z

tools/release/release.mts

@@ -43,12 +43,12 @@ const { projectsVersionData, workspaceVersion } = await releaseVersion({



This needs to be redone, you can leave it to me

Thank you so much!
It would be great if you could take care of that part - totally trust your judgment on it. Let me know if there's anything you'd like me to adjust on my side!

Jester175 · 2025-07-09T19:23:12Z

Thanks for this @xaos7991!

Please kindly take a look at all the inline comments.

Additionally:

The changes to the dependency and task graphs of the workspace through this change of package manager are unexpected and make me nervous that scope creep has occurred. Can we achieve this change of package manager without changing the relationships in the repo please? If they need to be changed for correctness let's please discuss and potentially address in a follow up (or pre-requisite PR)

I am not familiar enough with -w exec so I will need to check out the PR to play with that in all the subpackages, which I will do when other tasks have been addressed.

I will push a commit to change the release setup once all other TODOs are addressed and the PR is green again

During our work, we discovered that specifying a version like: "@typescript-eslint/rule-schema-to-typescript-types": "^8.36.0" - results in a 404 error from the npm registry.

However, referencing it as a workspace: "@typescript-eslint/rule-schema-to-typescript-types": "workspace:*" - works as expected with pnpm.

It seems this package isn't published publicly and is meant to be used internally within the monorepo. Might be worth clarifying to avoid confusion.

github-actions · 2025-07-09T19:23:25Z

Uh oh! @Jester175, at least one image you shared is missing helpful alt text. Check #11248 (comment) to fix the following violations:

Images should have meaningful alternative text (alt text) at line 16

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

xaos7991 and others added 30 commits May 18, 2025 21:32

feat: migrated to pnpm

0b9c67d

refactor: removed .yarn folder fix: changed overrides approach feat: changed references

fix: replaced the variable with your own path

d78c30d

fix: changed init path

e738b1b

fix: added files to ignore

8227be7

fix: changed init path

e1080b5

Merge pull request #2 from xaos7991/replacing-variables

ae63c55

Replacing variables

chore: migrated scripts from yarn to pnpm

e4500eb

chore: migrate scripts to pnpm

78f97ca

chore: replaced yarn reference with pnpm

b2740d3

chore: replaced yarn reference with pnpm

47bca3f

Merge pull request #4 from xaos7991/chore/migrate-scripts-to-pnpm

caae48b

Migrate scripts to pnpm and replaced yarn reference

chore: replaced yarn reference with pnpm

6ff72a1

Merge pull request #5 from xaos7991/chore/migrate-scripts-to-pnpm

83ea658

Replaced yarn reference with pnpm

chore: added rule schema types

df07c3c

Merge pull request #6 from xaos7991/chore/add-rule-schema-types

0ffc5cc

Added rule schema types

chore: fixed types

feb01b1

Merge pull request #7 from xaos7991/chore/types

9ed6376

Fixed types

ci: migrated yarn to pnpm

a497ac5

fix: resolved issues with eslint-plugin tests

351de42

chore: migrated to pnpm

03bd8d3

Merge pull request #8 from xaos7991/chore/launching-app-pnpm

1de3fca

Launching app pnpm

fix: resolved problems with versions of babel packages

77ca6dd

fix: resolved problems with babel types

644216b

Merge pull request #9 from xaos7991/fix/babel-types

0fe7f92

Resolved problems with babel types

docs: updated comments to reflect pnpm usage instead of yarn

a6f9007

Merge pull request #10 from xaos7991/chore/docs-update-pnpm-comments

08f458c

docs: updated comments to reflect pnpm usage instead of yarn

ci: migrated from yarn to pnpm

de5ee8b

ci: removed pnpm version

46e0620

fix: added dependency ignore configuration

88af74c

fix: added dependency ignore configuration

7e51137

Jester175 and others added 2 commits June 16, 2025 15:27

Merge branch 'main' into migrate-to-pnpm

547238c

Merge branch 'main' into migrate-to-pnpm

814e5d9

# Conflicts: # package.json # packages/eslint-plugin/package.json # packages/type-utils/package.json # packages/website/package.json # yarn.lock

xaos7991 force-pushed the migrate-to-pnpm branch from ebfcbff to 09b0f85 Compare June 17, 2025 14:02

fix: merge conflicts

5de32f8

fix: resolved conflicts fix: corrected the version

xaos7991 force-pushed the migrate-to-pnpm branch from 09b0f85 to 5de32f8 Compare June 17, 2025 14:53

xaos7991 added 2 commits June 17, 2025 18:02

fix: got rid of yarn

2547549

Merge branch 'main' into migrate-to-pnpm

c172330

kirkwaiblinger mentioned this pull request Jun 24, 2025

Repo: "*" should not be used which maybe broken with yarn-berry-deduplicate #11266

Open

xaos7991 and others added 6 commits June 28, 2025 09:17

Merge branch 'main' into migrate-to-pnpm

9b2dea0

# Conflicts: # CONTRIBUTORS.md # packages/eslint-plugin/package.json # packages/type-utils/package.json # tools/scripts/generate-contributors.mts # yarn.lock

fix(integration-tests): rewrite snapshot

559deed

Merge branch 'main' into migrate-to-pnpm

dc6b52f

Merge branch 'main' into migrate-to-pnpm

6378466

# Conflicts: # packages/eslint-plugin/package.json # packages/type-utils/package.json # yarn.lock

chore: bump pnpm version

2b44b0a

xaos7991 added 6 commits July 5, 2025 11:19

Merge branch 'main' into migrate-to-pnpm

a3c82cd

# Conflicts: # tools/scripts/generate-sponsors.mts # yarn.lock

fix: resolved lint issue

fd1df19

Merge branch 'main' into migrate-to-pnpm

d214d1b

fix: got rid of yarn

50e3938

fix: added dependency to build

c123198

fix: resolved issue

aafacea

kirkwaiblinger requested a review from a team July 6, 2025 22:22

JamesHenry requested changes Jul 8, 2025

View reviewed changes

Jester175 and others added 3 commits July 9, 2025 11:33

Merge remote-tracking branch 'origin/main' into migrate-to-pnpm

aa07223

fix: resolved issue

6da2a7a

fix: try to get rid of checkout

75e3231

Merge branch 'main' into migrate-to-pnpm

a864d53

xaos7991 requested a review from JamesHenry July 9, 2025 19:23


		YARN_ENABLE_IMMUTABLE_INSTALLS=false yarn install
		pnpm install

		@@ -43,12 +43,12 @@ const { projectsVersionData, workspaceVersion } = await releaseVersion({

Uh oh!

chore: migrate to pnpm #11248

Are you sure you want to change the base?

chore: migrate to pnpm #11248

Conversation

xaos7991 commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

Overview

Uh oh!

xaos7991 commented Jul 1, 2025

Uh oh!

JamesHenry left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Jester175 commented Jul 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 9, 2025

Uh oh!

Uh oh!

xaos7991 commented May 27, 2025 •

edited

Loading

Jester175 commented Jul 9, 2025 •

edited

Loading