【BUG】koa render will break all API request

[Gcaufy]

When use @Render in Koa, it will break all api request, all API request will return a html template.

How to produce

1. Create a html render controller

// html/default.ts
@Controller()
export default class DefaultController {
  @Get('/homepage')
  @Render('home/index')
  async index() {
    return {
      title: config.app.name,
    };
  }
}

2. Create a api json controller

// api/default.ts
@JsonController()
export default class DefaultController {
  @Get("/api/users")
  getAll() {
    return {
      code: 0,
      data: [{ name: 'Jim Green', id: 1 }]
    };
  }

3. Test

curl http://localhost/api/users    // show json as expected
curl http://localhost/homepage   // show HTML page as expected
curl http://localhost/api/users    // show HTML page (!!NOT EXPECTED!!)

Reason code

routing-controllers/src/driver/koa/KoaDriver.ts

Lines 245 to 251 in 2455688

	} else if (action.renderedTemplate) { // if template is set then render it // TODO: not working in koa
	const renderOptions = result && result instanceof Object ? result : {};
	this.koa.use(async function (ctx: any, next: any) {
	await ctx.render(action.renderedTemplate, renderOptions);
	});
	}

in KoaDriver.ts, handleSuccess will register a render middleware. so that every request will goes to the middleware, even a JSON api.

[beclass]

Has this not been updated to the main branch yet? Now, after each installation, it is necessary to modify this file separately

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.