-
Notifications
You must be signed in to change notification settings - Fork 8
Add process to rebuild Share from a transcript #4
Conversation
d5c0f2f
to
46d359a
Compare
init-share.md
Outdated
.> pull [email protected]:unisonweb/base:.releases._latest .unison.base | ||
.> pull [email protected]:unisonweb/http:.releases._latest .unison.http | ||
.> pull [email protected]:unisonweb/distributed:.trunk .unison.distributed | ||
.> pull [email protected]:stew/unison-remote:.trunk .unison.remote |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stew we weren't sure if you wanted Remote to be under the new unison
org in Unison Share or under your user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list was somewhat made from https://github.com/unisonweb/shipwright/blob/trunk/files/initialize-codebase.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that unison-remote
can probably be ditched, as it has more or less been replaced by unisonweb/distributed
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stew are you ok with removing that library or do you want it still under your user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, we should ditch it
46d359a
to
6f72c45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little paranoid, so I'm imagining a user with the github handle stdlib
coming along and now that we don't have a .contrib
prefix there is a confusing stdlib.http
entry in our top-level namespace 😅. But with the transcript approach here, the PR reviewer could easily just recognize that this might be confusing and change it to another namespace.
init-share.md
Outdated
|
||
.> pull [email protected]:rlmark/parsing:.wip .rlmark.parsing | ||
.> pull [email protected]:rlmark/my-unison-repo2:.docsBeta .rlmark.docs | ||
.> pull [email protected]:rlmark/frog:.Oct13 .frog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be .rlmark.frog
or .unison.frog
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this is a bit unclear, but frog
(we really need another name) is a whole collection of projects, so it's on the top level like a "project org". Like what you see on GitHub (ex: https://github.com/rails) — We could nest this under Unison, but that might be better when the frog family of projects are more mature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also do a pull
for each frog library on separate lines to make this more clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. So what's 🐸? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated this to be .frog.frog
for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay but I still am interested in what the frog collection of projects is :)
Is this related to the HTTP lib that you and Rebecca have been working on? Instead of Ruby on Rails are we going to have Unison on Frogs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a set of utilities for http, (middleware, routing, url parsing) and yes, we do need a different library name - frog was a placeholder until we found a more suitable name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ribbit on Rails! 🐸
6f72c45
to
09419e8
Compare
I think this is a very valid concern, and we have to make sure we review changes to this file correctly. Long term this structure will be enforced by more realized Unison concepts like orgs and users and projects and through tool, like a ucm command for publishing. |
When we add a README to base that includes it's version we can enable this: unisonweb/codebase-ui#205 |
Replace the previous process of going through the Unison PR process for publishing on Unison Share with a Unison transcript that pulls Unison projects from other GitHub repositories maintained by the authors.
09419e8
to
c2d177d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I'm cool with merging this whenever y'all think it's ready!
Replace the previous process of going through the Unison PR process for
publishing on Unison Share with a Unison transcript that pulls Unison
projects from other GitHub repositories maintained by the authors.
This also changes the namespace structure of Unison Share to have every project nested under an organization or user, such that
base
now exists underunison.base
andparsing
exists underrlmark.parsing
instead ofcontrib.rlmark.parsing
.Caveat
We did not know the GitHub repository for all projects that currently are on Unison Share and we need to reach out to the team and contributors to re-add the projects to Unison Share. That said, we do have a copy of the old codebase that we can pull from if need be.