Skip to content
This repository was archived by the owner on Jul 13, 2022. It is now read-only.

Add process to rebuild Share from a transcript #4

Merged
merged 4 commits into from
Oct 15, 2021
Merged

Conversation

hojberg
Copy link
Member

@hojberg hojberg commented Oct 14, 2021

Replace the previous process of going through the Unison PR process for
publishing on Unison Share with a Unison transcript that pulls Unison
projects from other GitHub repositories maintained by the authors.

This also changes the namespace structure of Unison Share to have every project nested under an organization or user, such that base now exists under unison.base and parsing exists under rlmark.parsing instead of contrib.rlmark.parsing.


Caveat

We did not know the GitHub repository for all projects that currently are on Unison Share and we need to reach out to the team and contributors to re-add the projects to Unison Share. That said, we do have a copy of the old codebase that we can pull from if need be.

@hojberg hojberg requested review from stew, ceedubs and rlmark October 14, 2021 20:27
@hojberg hojberg force-pushed the init-transcript.md branch from d5c0f2f to 46d359a Compare October 14, 2021 20:27
init-share.md Outdated
.> pull [email protected]:unisonweb/base:.releases._latest .unison.base
.> pull [email protected]:unisonweb/http:.releases._latest .unison.http
.> pull [email protected]:unisonweb/distributed:.trunk .unison.distributed
.> pull [email protected]:stew/unison-remote:.trunk .unison.remote
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stew we weren't sure if you wanted Remote to be under the new unison org in Unison Share or under your user?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that unison-remote can probably be ditched, as it has more or less been replaced by unisonweb/distributed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stew are you ok with removing that library or do you want it still under your user?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, we should ditch it

@hojberg hojberg requested a review from pchiusano October 14, 2021 20:31
@hojberg hojberg force-pushed the init-transcript.md branch from 46d359a to 6f72c45 Compare October 14, 2021 20:33
Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little paranoid, so I'm imagining a user with the github handle stdlib coming along and now that we don't have a .contrib prefix there is a confusing stdlib.http entry in our top-level namespace 😅. But with the transcript approach here, the PR reviewer could easily just recognize that this might be confusing and change it to another namespace.

init-share.md Outdated

.> pull [email protected]:rlmark/parsing:.wip .rlmark.parsing
.> pull [email protected]:rlmark/my-unison-repo2:.docsBeta .rlmark.docs
.> pull [email protected]:rlmark/frog:.Oct13 .frog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be .rlmark.frog or .unison.frog?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this is a bit unclear, but frog (we really need another name) is a whole collection of projects, so it's on the top level like a "project org". Like what you see on GitHub (ex: https://github.com/rails) — We could nest this under Unison, but that might be better when the frog family of projects are more mature.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also do a pull for each frog library on separate lines to make this more clear.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. So what's 🐸? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this to be .frog.frog for now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay but I still am interested in what the frog collection of projects is :)

Is this related to the HTTP lib that you and Rebecca have been working on? Instead of Ruby on Rails are we going to have Unison on Frogs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a set of utilities for http, (middleware, routing, url parsing) and yes, we do need a different library name - frog was a placeholder until we found a more suitable name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ribbit on Rails! 🐸

@hojberg hojberg force-pushed the init-transcript.md branch from 6f72c45 to 09419e8 Compare October 14, 2021 21:11
@hojberg
Copy link
Member Author

hojberg commented Oct 14, 2021

I'm a little paranoid, so I'm imagining a user with the github handle stdlib coming along and now that we don't have a .contrib prefix there is a confusing stdlib.http entry in our top-level namespace

I think this is a very valid concern, and we have to make sure we review changes to this file correctly. Long term this structure will be enforced by more realized Unison concepts like orgs and users and projects and through tool, like a ucm command for publishing.

@hojberg
Copy link
Member Author

hojberg commented Oct 14, 2021

When we add a README to base that includes it's version we can enable this: unisonweb/codebase-ui#205

Replace the previous process of going through the Unison PR process for
publishing on Unison Share with a Unison transcript that pulls Unison
projects from other GitHub repositories maintained by the authors.
@hojberg hojberg force-pushed the init-transcript.md branch from 09419e8 to c2d177d Compare October 14, 2021 21:46
Copy link
Member

@pchiusano pchiusano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I'm cool with merging this whenever y'all think it's ready!

@hojberg hojberg merged commit bcd64bb into trunk Oct 15, 2021
@hojberg hojberg deleted the init-transcript.md branch October 15, 2021 18:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants