Add ValkeyNodeDescription, Rename ServerAddress, and Add Connection Pool Components Summary

[fabianfett]

This PR introduces several improvements to the node management and connection pool functionality:

• Added ValkeyNodeDescription to represent node metadata
• Renamed ServerAddress to ValkeyServerAddress and moved it to a dedicated file
• Added ValkeyNodeConnectionPool protocol for managing node connections
• Created ValkeyNodeConnectionPoolFactory protocol for connection pool instantiation

Motivation

These changes are made to allow easier testability of the cluster types that will follow in follow up PRs.

Changes

1. ValkeyNodeDescription
   Added a new type that represents metadata about a Valkey node, containing information such as the node's address, health status, and other relevant properties.

2. ServerAddress Rename
   Renamed ServerAddress to ValkeyServerAddress and moved it to its own file for better organization and to align with the naming convention of other components.

3. Connection Pool Components
   Added two new protocols:

• ValkeyNodeConnectionPool: Defines the interface for managing connections to a Valkey node
• ValkeyNodeConnectionPoolFactory: Provides a mechanism for creating connection pools as needed

[github-actions]

✅ Pull request no significant performance differences ✅

Summary

New baseline 'pull_request' is WITHIN the 'main' baseline thresholds.

Full Benchmark Comparison

Comparing results between 'main' and 'pull_request'

Host '38bc15fe3a12' with 2 'x86_64' processors with 7 GB memory, running:
#14~24.04.1-Ubuntu SMP Thu Apr 24 17:41:03 UTC 2025

ValkeyBenchmarks

GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	4	4	4	4	4	11	11	11
pull_request	4	4	4	4	4	11	11	11
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

HashSlot – {user}.whatever metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	21
pull_request	0	0	0	0	0	0	0	21
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

ValkeyCommandEncoder – Command with 7 words metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	747
pull_request	0	0	0	0	0	0	0	740
Δ	0	0	0	0	0	0	0	-7
Improvement %	0	0	0	0	0	0	0	-7

ValkeyCommandEncoder – Simple GET metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	1956
pull_request	0	0	0	0	0	0	0	1943
Δ	0	0	0	0	0	0	0	-13
Improvement %	0	0	0	0	0	0	0	-13

ValkeyCommandEncoder – Simple MGET 15 keys metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	364
pull_request	0	0	0	0	0	0	0	360
Δ	0	0	0	0	0	0	0	-4
Improvement %	0	0	0	0	0	0	0	-4

[adam-fowler]

Should this conform to ValkeyNodeDescriptionProtocol

[fabianfett]

It doesn't need to. ValkeyNodeDescription is our real currency type. But I don't want to force adopters to give us ValkeyNodeDescription directly. Instead they can use ValkeyNodeDescriptionProtocol representations.

[adam-fowler]

So you have two APIs? One for ValkeyNodeDescriptionProtocol and one for ValkeyNodeDescription? Or are you going to create a ValkeyNodeDescription from the supplied ValkeyNodeDescriptionProtocol.

[fabianfett]

Or are you going to create a ValkeyNodeDescription from the supplied ValkeyNodeDescriptionProtocol.

Internally we only use ValkeyNodeDescription. ValkeyNodeDescriptionProtocol is its public equivalent.

[adam-fowler]

Have these changes been propagated back to the PostgresNIO connection pool?

[fabianfett]

Not yet.

[adam-fowler]

You need to fix the tests as they are still referencing ServerAddress

[fabianfett]

Done.