[feat] Claims - endpoints for Claiming a resource #4
+177
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alex-vercel
deleted the
alexmartin/vmkt-291-handle-partner-api-endpoints-in-our-example-integration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New API endpoints for the Claim/transfer flow (create/verify/complete).
NOTE 1: This uses an in-memory array to 'persist' test claims between creation, verification and completion - this array will not live very long but it should be sufficient for an end-to-end test to pass. If we need something longer-lived we can integrate ephemeral Redis but that seems like overkill for this example repo.
NOTE 2: I have also assumed the naming convention for claim IDs should be
claim_XXXXXXXX- I'm not sure if that's a safe assumption or not.NOTE 3: I have added 2 GET endpoints to GET claims (either all in the in-mem array, or a specific one by ID) - this isn't in the spec but was very helpful when developing the APIs and I suspect will be useful when debugging the connection between this and the Vercel APIs.