Skip to content

Allow function name which starts with underscore #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 2, 2019

Conversation

tyru
Copy link
Member

@tyru tyru commented Aug 1, 2019

Fix #133

@tyru tyru requested a review from blueyed August 1, 2019 16:39
@blueyed
Copy link
Contributor

blueyed commented Aug 1, 2019

LGTM, needs to generate py/js.

@blueyed
Copy link
Contributor

blueyed commented Aug 1, 2019

Should we only run Travis for master branches (from origin) - or should we use forks for PRs?
(I mean that here Travis ran two times, for the PR and then also for the branch on the main repo)

@tyru
Copy link
Member Author

tyru commented Aug 2, 2019

travis-ci/pr and travis-ci/push check the pull request branch and merged branch (I forgot which one check that).
master may be changed after push, so we need both.

@tyru tyru merged commit fa4eec0 into master Aug 2, 2019
@tyru tyru deleted the func-underscore-prefix branch August 2, 2019 10:42
@tyru
Copy link
Member Author

tyru commented Aug 2, 2019

thanks for view.

@tyru
Copy link
Member Author

tyru commented Aug 2, 2019

s/view/review/

@blueyed
Copy link
Contributor

blueyed commented Aug 3, 2019

travis-ci/pr and travis-ci/push check the pull request branch and merged branch (I forgot which one check that).
master may be changed after push, so we need both.

The important one is the "pr" check (which tests the merge with master).
The other checks the branch as-is (and there it might pass, although it fails for the merge).
Therefore usually testing "pr" for PRs is fine - and happens when creating the PR from a fork (and not the main repo). When using the main repo for PRs also, you usually configure Travis to only build the master branch, and release tags.

blueyed added a commit to blueyed/vim-vimlparser that referenced this pull request Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vimlparser doesn't allow function name which starts with '_'
2 participants