fix(devtools): clear performance measures

[awaken1ng]

close #13700

perf markers still seem to appear on the profiler timeline in Firefox and Chrome

Summary by CodeRabbit

• Refactor
  • Improved internal handling of performance measurement names for component profiling, with no changes to user-facing functionality.

[coderabbitai]

Walkthrough

The endMeasure function in the profiling module was updated to use a local variable for the formatted measure name and now explicitly calls both perf.measure and perf.clearMeasures to manage performance measures. No changes were made to the function's signature or other logic.

Changes

File(s)	Change Summary
packages/runtime-core/src/profiling.ts	Refactored endMeasure to use a local variable for measure name and added explicit clearMeasures call.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

The profiler hops with nimble care,
Clearing old traces from the air.
With names in paws, it marks the spot,
Then sweeps the measures, leaves no clot.
Now Firefox runs fast and bright—
A rabbit’s touch makes code just right! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c486536 and 099d061.

📒 Files selected for processing (1)

• packages/runtime-core/src/profiling.ts (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

packages/runtime-core/src/profiling.ts (1)

packages/runtime-core/src/component.ts (1)

• formatComponentName (1219-1249)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Redirect rules
• GitHub Check: Header rules
• GitHub Check: Pages changed

🔇 Additional comments (3)

packages/runtime-core/src/profiling.ts (3)

31-31: Good refactoring to extract measure name creation.

Introducing the local variable improves code readability and ensures consistency between the perf.measure and perf.clearMeasures calls.

---

34-34: Critical fix: Properly clear performance measures to prevent memory leaks.

This addition resolves the core issue by explicitly clearing performance measures after they're created. Without this cleanup, measures would accumulate indefinitely, potentially causing memory leaks and performance degradation over time.

---

33-34: Perfect implementation of the performance measures cleanup fix.

The changes successfully address the PR objective of clearing performance measures. The implementation:

• Uses the extracted measureName variable consistently
• Properly follows the Performance API cleanup pattern
• Maintains all existing functionality while fixing the memory leak

This resolves issue #13700 effectively.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	101 kB	38.4 kB	34.6 kB
vue.global.prod.js	159 kB (-19 B)	58.6 kB (-6 B)	52.2 kB (+47 B)

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	46.6 kB	18.2 kB	16.7 kB
createApp	54.6 kB	21.2 kB	19.4 kB
createSSRApp	58.8 kB	23 kB	20.9 kB
defineCustomElement	59.6 kB	22.8 kB	20.8 kB
overall	68.7 kB	26.4 kB	24.1 kB

[pkg-pr-new]

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13701

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13701

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13701

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13701

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13701

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13701

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13701

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13701

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13701

vue

npm i https://pkg.pr.new/vue@13701

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13701

commit: 099d061