Skip to content

Add type inference for emitted events #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 11, 2021
Merged

Add type inference for emitted events #800

merged 2 commits into from
Jan 11, 2021

Conversation

NataliaTepluhina
Copy link
Member

Description of Problem

Currently, we don't have emits property described in the TS guide

Proposed Solution

This PR adds a small example for emits

Additional Information

Close #776

@NataliaTepluhina NataliaTepluhina self-assigned this Jan 10, 2021
skirtles-code
skirtles-code approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeScript is a bit of a mystery to me, but to my untrained eye everything seems fine. I tried running the code and got the expected type errors.

I made a suggestion about one line but it's nothing important.

@NataliaTepluhina NataliaTepluhina merged commit 4f4a5e6 into master Jan 11, 2021
@NataliaTepluhina NataliaTepluhina deleted the add-emits-type-declaration branch February 24, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirtles-code skirtles-code skirtles-code approved these changes

@bencodezen bencodezen Awaiting requested review from bencodezen

Assignees

@NataliaTepluhina NataliaTepluhina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add about type inference of emits option into TS Documentation
2 participants
@NataliaTepluhina @skirtles-code