Update declaration #218
Update declaration #218
Conversation
|
Looks great - in the meanwhile, I'm trying to merge |
|
Sure! I will rebase that. |
| dispatch(mutationName: string, ...args: any[]): void; | ||
| dispatch<P>(mutation: MutationObject<P>): void; | ||
|
|
||
| watch(path: string, cb: (value: any) => void, options?: WatchOption): void; |
There was a problem hiding this comment.
I've merged next into master and this is the only thing that is deprecated. LGTM after removing this.
|
I've removed it :) |
|
Thanks! Sorry for the back and forth, but I just pushed some additional changes for 1.0 today. In brief:
Also see (the latest api reference)[https://github.com/vuejs/vuex/blob/master/docs/en/api.md]. |
|
OK, I'll add the types for them a little later! |
- middlewares -> plugins - new method: replaceState, on, once, off and emit
|
I'm done. |
|
Great work, thank you very much! Do we need to do anything to publish this to typings? |
|
We need to send PR to typings/registry with a json file like this. |
|
@ktsn sure! |
* upstream/master: (52 commits) Update ja document (vuejs#240) small word correction (vuejs#257) Modify type files to external module definition format to publish them via npm (vuejs#242) update docs for 1.0-rc.2 Fix typo of docs (vuejs#238) [release] 1.0.0-rc.2 [build] 1.0.0-rc.2 improve type test for subscribe update type definition for subscribe store.on(mutation) -> store.subscribe Update types for nested modules (vuejs#235) update plugins doc [release] 1.0.0-rc [build] 1.0.0-rc ignore explorations Update declaration (vuejs#218) add renamed logger include events methods in api reference expose replaceState() docs ...
Related to #215
I moved all type-related files to
typesdirectory.And I added test cases for the d.ts file. You can run the test cases by executing the following command. (It's ok if there are no error is printed)