Fix decoding dynamic tuples and arrays with dynamic subtypes within tuples #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaroslavyaroslav
approved these changes
Mar 21, 2022
mloit
reviewed
Mar 21, 2022
| if !subType.isStatic { | ||
| consumed = consumedUnwrapped | ||
| } else { | ||
| fallthrough |
There was a problem hiding this comment.
do not use fallthrough. in this case it will drop down to the next case, and it looks for !subTypes[i].isStatic which as it was an array will process as true, and do consumed = consumedUnwrapped instead of falling down to the default and doing consumed = consumed + consumedUnwrapped as intended.
As a general rule, don't ever use fallthrough unless absolutely necessary, and you fully understand all the potential side-effects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #429 . When decoding a tuple that is not static or an array with a subtype that is not static, the second value in the tuple returned by
decodeSignleTypeis a pointer to the next element, NOT the length of the consumed element. So when decoding such an element within a tuple,consumedshould be set to consumedUnwrapped, NOT incremented by consumedUnwrapped.