Provide basic tolerance to EIP-1559 data #467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test for the envelope 'type' if 0 or not present we assume legacy and can continue, otherwise abort as it is 1559 [or future] and we don't know its encoding Added some basic garbage-in garbage out checks to prevent calculations from generating an overflow. This will mean what comes out is garbage, but at least it didn't crash.
pharms-eth
suggested changes
Mar 16, 2022
pharms-eth
approved these changes
Mar 16, 2022
|
Just a heads up: This PR will soon be obsoleted by a new one coming in the next few days that brings in EIP-2718, EIP-2930, and EIP-1559 with full encode/decode support |
|
@mloit should i merge it or wait for coming one? |
you can merge it. While I may get the PR out before your Wednesday time [took a break to do something else today] I expect it will take a while to be evaluated and reviewed. |
yaroslavyaroslav
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides some basic tolerance if a EIP-1559 [or future] unknown envelope is encountered. Decoding is abandoned if the field type is present and not 0. Otherwise if 0 or not present decoding is allowed as it is a legacy encoding.
Also included are some range checks at specific places to prevent the overflow condition from happening that results in the precondition trigger in the BigUInt library from halting execution. The result of the subsequent calculation will be incorrect, but the data going in was incorrect anyway... at least it doesn't crash.
fixes #463