Skip to content

Change UINT64_MAX to UInt64.max #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 15, 2022
Merged

Change UINT64_MAX to UInt64.max #482

merged 3 commits into from
Mar 15, 2022

Conversation

mloit
Copy link
Contributor

@mloit mloit commented Mar 14, 2022

Updated to the 'Swift Way' of using the Numeric Protocol, and query the type [UInt64] for max instead of relying on the external OS [Darwin] specific UINT64_MAX

…he type for max instead of relying on the external OS [Darwin] specific UINT64_MAX
@mloit mloit changed the title Change UINT64_MAX to Uint64.max Change UINT64_MAX to UInt64.max Mar 14, 2022
@yaroslavyaroslav yaroslavyaroslav self-requested a review March 15, 2022 15:21
This is recursion dependency file which were deleted from repo.
This is recursion dependency file which were deleted from repo.
@yaroslavyaroslav
Copy link
Collaborator

Files in ./**/Pods/* folders were building dependencies and were dropped shortly, so i delete your changes in it. At the same time i'm approving your change of the main source code changes and it will be merged shortly.
Thank you for your work.

@yaroslavyaroslav yaroslavyaroslav merged commit 39b76e6 into web3swift-team:develop Mar 15, 2022
@yaroslavyaroslav yaroslavyaroslav removed their request for review March 15, 2022 17:54
@mloit mloit deleted the use-swift-numeric branch March 15, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants