Skip to content

remove: Promises/Promise+Web3+Contract+GetIndexedEvents.swift #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2022
Merged

remove: Promises/Promise+Web3+Contract+GetIndexedEvents.swift #496

merged 2 commits into from
Mar 23, 2022

Conversation

mloit
Copy link
Contributor

@mloit mloit commented Mar 22, 2022

File is empty and unused since 2018, I'm pretty sure we don't need it.

This has been pulled out into a separate PR because it was causing the automated Carthage test to fail

@yaroslavyaroslav
Copy link
Collaborator

Yep, as i see you've just deleting a file directly from disk, but not deleting it through web3swift.xcproject, so since Carthage expects that file within the project, haven't founding it and failed to build due to incomplete sources. Deleting the very same file within such project should fix that building issue.

@mloit
Copy link
Contributor Author

mloit commented Mar 23, 2022

Yep, as i see you've just deleting a file directly from disk, but not deleting it through web3swift.xcproject, so since Carthage expects that file within the project, haven't founding it and failed to build due to incomplete sources. Deleting the very same file within such project should fix that building issue.

Oh, that would explain it... wonder why XCode isn't updating the file for me. I use both VS Code and XCode in parallel. I'll manually edit the file and resubmit, and keep it in mind for the future.

@yaroslavyaroslav yaroslavyaroslav merged commit c781699 into web3swift-team:develop Mar 23, 2022
@mloit mloit deleted the feature/remove-unused-file branch March 23, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants