Skip to content

Bug fix/transaction index #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2022
Merged

Bug fix/transaction index #521

merged 2 commits into from
Apr 15, 2022

Conversation

mloit
Copy link
Contributor

@mloit mloit commented Apr 14, 2022 •
edited
Loading

Quick PR to restore some things that got reverted along the way.

  1. Restore the fix in Fix for transactionIndex incorrectly returning blockNumber #484 (originally Fix for transactionIndex incorrectly returning blockNumber #465) that fixed transactionIndex incorrectly being decoded using the blockNumber key
  2. Restore the lint cleanup (Feature/pre swiftlint cleanup #495) in Web3+Structures that was undone along the way

@yaroslavyaroslav yaroslavyaroslav merged commit 41337df into web3swift-team:develop Apr 15, 2022
@mloit mloit deleted the bug-fix/transaction-index branch April 15, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mloit @yaroslavyaroslav