fix: `loaderUtils.parseQuery()` deprecation warning (`loader-utils`) #57

mitkaaa · 2017-04-17T10:43:23Z

Special fix for the latest version of the loader-utils(^1.1.0)
Removes warning when transpiling the webpack

Add idPrefix option

…b#36

add missing idPrefix as default value to config

Multiple classses in class attribute not prefixed when using classPrefix

multiple classes in class string, fix for Issue webpack-contrib#39

For CSS properties that contain '.' in the value.

multiple classes in class string, fix issue webpack-contrib#39

Fix issue 41

add warnTags and warnTagAttrs

[fix] don't transform webpack2 query objects

Add license file

closes webpack-contrib#53

jsf-clabot · 2017-04-17T10:43:24Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 10 committers have signed the CLA.

✅ sairion
✅ d3viant0ne
✅ mitkaaa
❌ Jay Jaeho Lee
❌ noxan
❌ nonmanifold
❌ alok pepakayala
❌ kinetifex
❌ Stuk
❌ =

Jay Jaeho Lee, alok pepakayala, = seem not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

alexander-akait · 2017-07-11T14:56:36Z

.travis.yml

@@ -0,0 +1,6 @@
+sudo: false


Don't add .travis.yml in this PR, we use webpack-defaults for all repositories https://github.com/webpack-contrib/webpack-defaults

joshwiens · 2017-07-12T19:59:12Z

index.js

@@ -59,10 +59,7 @@ function getExtractedSVG(svgStr, query) {
 function SVGInlineLoader(content) {
    this.cacheable && this.cacheable();
    this.value = content;
-    // Configuration
-    var query = loaderUtils.parseQuery(this.query);
-


This should still be required. var query = loaderUtils.getOptions(this) || {};

const options = loaderUtils.getOptions(this) && global rename query => options

michael-ciniawsky · 2017-07-14T15:18:44Z

index.js

@@ -59,10 +59,7 @@ function getExtractedSVG(svgStr, query) {
 function SVGInlineLoader(content) {
    this.cacheable && this.cacheable();
    this.value = content;
-    // Configuration
-    var query = loaderUtils.parseQuery(this.query);
-


const options = loaderUtils.getOptions(this) && global rename query => options

mitkaaa · 2017-08-07T07:57:53Z

I checked it works :)

joshwiens · 2017-08-09T07:47:19Z

This is going to need to be rebased

le0m · 2017-12-19T16:29:47Z

is there any update on this?
(cross-reference: #72)

joshwiens · 2017-12-21T06:33:00Z

@le0m - I'm going to take care of this in a separate PR as the loader utils change is not backwards compatible.

With Webpack 4 on the way, we are a bit buried at the moment, i'll try and get a beta build that handles the deprecation warning & Webpack 4 support before the end of the week.

jhnns · 2020-02-07T11:46:50Z

Fixed by https://github.com/webpack-contrib/svg-inline-loader/pull/72/files

vidal7 · 2020-02-07T12:02:43Z

Yeah! Thank you. @jhnns, I supposed that there will be a release soon on NPM registry? I don't see it on NPM yet.

vidal7 · 2020-02-10T16:04:47Z

@jhnns, I still don't see the release on npmjs

Jaeho Lee and others added 22 commits September 16, 2016 18:54

Merge pull request webpack-contrib#34 from p3drosola/master

a0bdf50

Add idPrefix option

0.7.0

9425192

add missing idPrefix as default value to config, close webpack-contri…

5bc999e

…b#36

Merge pull request webpack-contrib#37 from noxan/issue-36

d857951

add missing idPrefix as default value to config

0.7.1

ca7ef2d

warnTags and warnTagAttrs

2ffa1c0

Update README.md

6a2fb4a

multiple classes in class string fix

779f77e

Multiple classses in class attribute not prefixed when using classPrefix

Merge pull request webpack-contrib#1 from a10k/fix-issue-39

d6c05df

multiple classes in class string, fix for Issue webpack-contrib#39

Fix webpack-contrib#41 corrupted css properties in style tag

851316a

For CSS properties that contain '.' in the value.

[fix] don't transform webpack2 query objects

9b4e8a3

Merge pull request webpack-contrib#40 from a10k/fix-issue-39

2e803ec

multiple classes in class string, fix issue webpack-contrib#39

Merge pull request webpack-contrib#42 from a10k/fix-issue-41

32b2186

Fix issue 41

Merge pull request webpack-contrib#38 from nonmanifold/master

a119080

add warnTags and warnTagAttrs

Merge pull request webpack-contrib#44 from kinetifex/webpack2-query-fix

c2baa5e

[fix] don't transform webpack2 query objects

Add license file

4a0e589

Merge pull request webpack-contrib#46 from Stuk/license

353a56a

Add license file

Update license to js foundation license (fixes webpack-contrib#49)

7183d48

docs(readme): contrib standard readme (webpack-contrib#50)

4d34db6

docs(readme): remove bithound badge

41fd170

docs: Update usage documentation (webpack-contrib#54)

162af5b

closes webpack-contrib#53

fix for loader-utils

881da77

patrickskim approved these changes May 20, 2017

View reviewed changes

travis

5d5c8de

mitkaaa mentioned this pull request Jul 11, 2017

Any plans for more releases? #61

Closed

alexander-akait suggested changes Jul 11, 2017

View reviewed changes

joshwiens added pr_action: Review semver: Patch type: Refactor labels Jul 11, 2017

remove travis

c598bc5

joshwiens added semver: Major and removed semver: Patch labels Jul 12, 2017

joshwiens changed the title ~~fix for loader-utils~~ refactor: Update to latest loader-utils Jul 12, 2017

joshwiens reviewed Jul 12, 2017

View reviewed changes

michael-ciniawsky suggested changes Jul 14, 2017

View reviewed changes

michael-ciniawsky changed the title ~~refactor: Update to latest loader-utils~~ fix: loaderUtils.parseQuery() deprecation warning (loader-utils) Jul 14, 2017

michael-ciniawsky added type: Bug priority: 2 (urgent) semver: Major and removed semver: Major type: Refactor labels Jul 14, 2017

joshwiens force-pushed the master branch from 74045fd to ff568a9 Compare July 16, 2017 03:48

= and others added 2 commits August 1, 2017 22:03

Changed parseQuery to getOptions

3329341

Merge branch 'master' into master

2a3955f

le0m mentioned this pull request Dec 19, 2017

Upgrading loader utils to fix deprecation warning #72

Merged

jhnns closed this Feb 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: `loaderUtils.parseQuery()` deprecation warning (`loader-utils`) #57

fix: `loaderUtils.parseQuery()` deprecation warning (`loader-utils`) #57

Uh oh!

mitkaaa commented Apr 17, 2017

Uh oh!

jsf-clabot commented Apr 17, 2017 •

edited

Loading

Uh oh!

alexander-akait Jul 11, 2017

Uh oh!

mitkaaa Jul 12, 2017

Uh oh!

joshwiens Jul 12, 2017

Uh oh!

michael-ciniawsky Jul 14, 2017

Uh oh!

michael-ciniawsky Jul 14, 2017

Uh oh!

mitkaaa commented Aug 7, 2017

Uh oh!

joshwiens commented Aug 9, 2017

Uh oh!

le0m commented Dec 19, 2017 •

edited

Loading

Uh oh!

joshwiens commented Dec 21, 2017

Uh oh!

jhnns commented Feb 7, 2020

Uh oh!

vidal7 commented Feb 7, 2020 •

edited

Loading

Uh oh!

vidal7 commented Feb 10, 2020

Uh oh!

Uh oh!

fix: loaderUtils.parseQuery() deprecation warning (loader-utils) #57

fix: loaderUtils.parseQuery() deprecation warning (loader-utils) #57

Uh oh!

Conversation

mitkaaa commented Apr 17, 2017

Uh oh!

jsf-clabot commented Apr 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexander-akait Jul 11, 2017

Choose a reason for hiding this comment

Uh oh!

mitkaaa Jul 12, 2017

Choose a reason for hiding this comment

Uh oh!

joshwiens Jul 12, 2017

Choose a reason for hiding this comment

Uh oh!

michael-ciniawsky Jul 14, 2017

Choose a reason for hiding this comment

Uh oh!

michael-ciniawsky Jul 14, 2017

Choose a reason for hiding this comment

Uh oh!

mitkaaa commented Aug 7, 2017

Uh oh!

joshwiens commented Aug 9, 2017

Uh oh!

le0m commented Dec 19, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joshwiens commented Dec 21, 2017

Uh oh!

jhnns commented Feb 7, 2020

Uh oh!

vidal7 commented Feb 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vidal7 commented Feb 10, 2020

Uh oh!

Uh oh!

fix: `loaderUtils.parseQuery()` deprecation warning (`loader-utils`) #57

fix: `loaderUtils.parseQuery()` deprecation warning (`loader-utils`) #57

jsf-clabot commented Apr 17, 2017 •

edited

Loading

le0m commented Dec 19, 2017 •

edited

Loading

vidal7 commented Feb 7, 2020 •

edited

Loading