[WellSQL Migration] Migrate WCGlobalAttributeModel to Room

WooCommerce/src/main/kotlin/com/woocommerce/android/model/ProductGlobalAttribute.kt

@@ -2,35 +2,33 @@ package com.woocommerce.android.model
 
 import android.os.Parcelable
 import kotlinx.parcelize.Parcelize
+import org.wordpress.android.fluxc.model.LocalOrRemoteId.LocalId
+import org.wordpress.android.fluxc.model.LocalOrRemoteId.RemoteId
 import org.wordpress.android.fluxc.model.attribute.WCGlobalAttributeModel
 
 /**
  * Represents a global attribute, which is an attribute available store-wide
  */
 @Parcelize
 data class ProductGlobalAttribute(
-    val id: Int,
     val localSiteId: Int,
     val name: String,
     val slug: String,
     val type: String,
     val orderBy: String,
     val hasArchives: Boolean,
-    val termsId: String,
     val remoteId: Long
 ) : Parcelable {
     fun toDataModel(cachedAttribute: WCGlobalAttributeModel? = null): WCGlobalAttributeModel {
-        return (cachedAttribute ?: WCGlobalAttributeModel()).also {
-            it.id = id
-            it.localSiteId = localSiteId
-            it.name = name
-            it.slug = slug
-            it.type = type
-            it.orderBy = orderBy
-            it.hasArchives = hasArchives
-            it.termsId = termsId
-            it.remoteId = remoteId.toInt()
-        }
+        return cachedAttribute ?: WCGlobalAttributeModel(
+            siteId = LocalId(localSiteId),
+            remoteId = RemoteId(remoteId),
+            name = name,
+            slug = slug,
+            type = type,
+            orderBy = orderBy,
+            hasArchives = hasArchives,
+        )
     }
 
     /**
@@ -50,14 +48,12 @@ data class ProductGlobalAttribute(
 
 fun WCGlobalAttributeModel.toAppModel(): ProductGlobalAttribute {
     return ProductGlobalAttribute(
-        id = this.id,
-        remoteId = this.remoteId.toLong(),
-        localSiteId = this.localSiteId,
+        remoteId = this.remoteId.value,
+        localSiteId = this.siteId.value,
         name = this.name,
         slug = this.slug,
         type = this.type,
         orderBy = this.orderBy,
         hasArchives = this.hasArchives,
-        termsId = this.termsId
     )
 }

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/products/details/ProductDetailRepository.kt

@@ -309,7 +309,7 @@ class ProductDetailRepository @Inject constructor(
     /**
      * Returns a list of global attributes from the local db
      */
-    fun getGlobalAttributes(): List<ProductGlobalAttribute> {
+    suspend fun getGlobalAttributes(): List<ProductGlobalAttribute> {
         val wooResult = globalAttributeStore.loadCachedStoreAttributes(selectedSite.get())
         return wooResult.model?.map { it.toAppModel() } ?: emptyList()
     }

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/products/details/ProductDetailViewModel.kt

@@ -1903,7 +1903,7 @@ class ProductDetailViewModel @Inject constructor(
         }
     }
 
-    fun loadGlobalAttributes(): List<ProductGlobalAttribute> =
+    suspend fun loadGlobalAttributes(): List<ProductGlobalAttribute> =
         productRepository.getGlobalAttributes()
 
     /**