Remove EditPostActivity companion object
#22122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| App Name |  WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22122-8f91c58 | |
| Commit | 8f91c58 | |
| Direct Download | wordpress-prototype-build-pr22122-8f91c58.apk |
|
| App Name |  Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22122-8f91c58 | |
| Commit | 8f91c58 | |
| Direct Download | jetpack-prototype-build-pr22122-8f91c58.apk |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #22122 +/- ##
=======================================
Coverage 39.43% 39.43%
=======================================
Files 2149 2149
Lines 101872 101872
Branches 15604 15604
=======================================
Hits 40177 40177
Misses 58126 58126
Partials 3569 3569 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dcalhoun
approved these changes
Aug 13, 2025
oguzkocer
force-pushed
the
rename-editpostactivity-types
branch
from
35df0af to
27c7104
Compare
Eliminate EditPostActivity companion object and reorganize constants to prepare for GutenbergKitActivity duplication. Changes: - Move shareable constants to EditorConstants (NEW_MEDIA_POST family, timing constants, regex groups, RestartEditorOptions enum) - Move checkToRestart() method to EditorLauncher companion object - Add ViewPager constants back to EditPostActivity as private constants with VIEW_PAGER_ prefix (activity-specific implementation details) - Update all external references to use EditorLauncher.checkToRestart() - Update AnalyticsUtils to use EditorConstants.NEW_MEDIA_POST This eliminates the EditPostActivity companion object while making shareable constants available in EditorConstants. ViewPager configuration remains private to each activity.
oguzkocer
force-pushed
the
remove-editpostactivity-companion
branch
from
9b8b798 to
8f91c58
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Remove
EditPostActivitycompanion object to eliminate activity-specific dependencies beforeGutenbergKitActivityduplication. Move shareable constants toEditorConstantsand activity-specific constants to private fields.Changes
EditPostActivitycompanion object entirelyEditorConstantscheckToRestart()method toEditorLauncherViewPagerconstants to private fields withVIEW_PAGER_prefixNo Functional Changes
This PR contains only code organization changes. No business logic, behavior, or functionality has been modified.