Skip to content

check_rate_limit can fail if getStatus does not return any results #117

Closed
@cheops

Description

@cheops

check_rate_limit uses the url = "https://pvoutput.org/service/r2/getstatus.jsp" (and also wrongly uses the default _call method=requests.post)
but this can return an error, from the documentation:

Use the d parameter to request a specific date. When date is omitted, the last known live data in the last 7 days will be used.
A Bad request 400: No status found
No live data found on a specified date or no live data reported in the last 7 days when no date parameter is used.

the Get System Service with the method requests.get seems a safer bet

          url = "https://pvoutput.org/service/r2/getsystem.jsp"
          response = self._call(url, {}, headers=headers, method=requests.get)

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions