Skip to content

Enabling aws-sigv4 integration #392

@theawless

Description

@theawless

Hi, I wanted to enable the aws-sigv4 integration that was introduced with curl version 7.75. Multiple cloud providers use this scheme, but many don't have adequate rust clients (SDKs or signing libraries). I think it would be pretty nifty to have this feature supported out of the box in curl-rust (and hopefully in isahc). Q1. What are your thoughts on this?

Here's my work so far: master...theawless:aws-sigv4

  • added the aws-sigv4 method in the Easy, Easy2, and Auth structs
  • added aws-sigv4 related options in curl-sys lib
  • removed CURL_DISABLE_CRYPTO_AUTH from curl-sys build
  • added crypto-related files (digest, sha256, hmac, etc) to curl-sys build

I noticed that removing CURL_DISABLE_CRYPTO_AUTH automatically starts building NTLM which I didn't intend to. The already existing flag CURL_DISABLE_NTLM didn't seem to work. I noticed that curl got rid of that flag here in this commit. I haven't worked with curl before but I think it might be impacting other dependencies as well (at least the code search shows many instances). Q2: Do you think that this could be reverted and should I start a discussion at their end?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions