Add support for aws-sigv4 authentication #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theawless
commented
Jul 31, 2021
| .file("curl/lib/system_win32.c") | ||
| .file("curl/lib/version_win32.c") | ||
| .file("curl/lib/vauth/digest_sspi.c") |
|
Seems reasonable to me, thanks! I think it's ok to keep CI as is (building all the sets of features isn't always the most useful and can take a lot of time), and for file order in the build script it's pretty haphazard and not super principled, so wherever is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used these platforms:
I wasn't sure what feature combinations to build curl-rust with to test properly.
So, I wrote this script which runs all of them (1024 combinations).
Would it be useful to add it in the CI somehow?
For macOS and Linux, all builds work fine.
For Windows, some of them are breaking, but they had been breaking before my changes.
mesalink+spnegodoesn't build together on Windows. Is this expected?Closes #392