Skip to content

Modify index.js to support include_paths #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2015
Merged

Modify index.js to support include_paths #8

merged 2 commits into from
Nov 13, 2015

Conversation

jacooobi
Copy link
Contributor

As listed in spec

@fhwang
Copy link

fhwang commented Sep 30, 2015

It bums me out that we don't have real specs for these JS-driven engines. That being said, assuming the Circle CI issue can be fixed, LGTM.

@jacooobi
Copy link
Contributor Author

jacooobi commented Oct 6, 2015

@fhwang I think we had a similar problem in codeclimate CLI repo, it was resolved by editing the circle.yml. All gcloud related commands were removed from pre and are used only during deployment. Check it out here

ABaldwinHunter pushed a commit that referenced this pull request Oct 8, 2015
This change should allow tests to pass on PRs from forks

And fix #8
ABaldwinHunter pushed a commit that referenced this pull request Oct 8, 2015
This change should allow tests to pass on PRs from forks

And fix #8
ABaldwinHunter pushed a commit that referenced this pull request Oct 8, 2015
This change should allow tests to pass on PRs from forks

And fix #8
ABaldwinHunter pushed a commit that referenced this pull request Oct 8, 2015
This change should allow tests to pass on PRs from forks

And fix #8
@ABaldwinHunter ABaldwinHunter reopened this Oct 8, 2015
@ABaldwinHunter
Copy link
Contributor

@jacobi007 sorry! I didn't realize that github commit words could deal the samurai death star of closing a PR.

I updated the circle file on this repo, so if you rebase, we should see tests pass and then can merge on green.

This change should allow tests to pass on PRs from forks

And fix #8
@jacooobi
Copy link
Contributor Author

jacooobi commented Oct 9, 2015

@ABaldwinHunter done!

@ABaldwinHunter ABaldwinHunter merged commit b84763b into codeclimate:master Nov 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants