Skip to content

update registry reference for circle #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2015
Merged

Conversation

ABaldwinHunter
Copy link
Contributor

This change should allow tests to pass on PRs from forks

And fix #8

@codeclimate/review

@mxie
Copy link

mxie commented Oct 8, 2015

LGTM

@@ -4,6 +4,7 @@ machine:
environment:
CLOUDSDK_CORE_DISABLE_PROMPTS: 1
image_name: codeclimate-fixme
REGISTRY_ROOT: us.gcr.io/code_climate

dependencies:
pre:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 4 lines in this section need to move to the master section below

@ABaldwinHunter ABaldwinHunter force-pushed the abh-circle branch 2 times, most recently from e1b7aca to b53f184 Compare October 8, 2015 15:25
This change should allow tests to pass on PRs from forks

And fix #8
@ABaldwinHunter
Copy link
Contributor Author

@codeclimate/review updated following codeclimate-rubocop circle.yml - gold standard

(I noticed that no tests actually get run atm, so we may want to add some in a different PR.)

@gdiggs
Copy link
Contributor

gdiggs commented Oct 8, 2015

LGTM

ABaldwinHunter pushed a commit that referenced this pull request Oct 8, 2015
update registry reference for circle
@ABaldwinHunter ABaldwinHunter merged commit f73d1da into master Oct 8, 2015
@ABaldwinHunter ABaldwinHunter deleted the abh-circle branch October 8, 2015 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants