Port #3399 to release/5.1 #3408
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen symmetric key decryption fails using Always Encrypted. (#1968)
…, Pooling is disabled and network connection type is Redirect (#1967)
Update dependency versions for Azure Identity, Azure Core, MSAL, and DiagnosticSource. Addresses Azure Identity vulnerability.
…aged identity (#2360) (#2473) (#2478) * Remove test reference to deprecated ADAL library (#2360) * Test | Updating tests to acquire token from user-assigned managed identity (#2473) Co-authored-by: David Engel <[email protected]> --------- Co-authored-by: David Engel <[email protected]> Co-authored-by: Javad Rahnama <[email protected]> Co-authored-by: David Engel <[email protected]>
Co-authored-by: Javad <[email protected]>
Successful run: https://sqlclientdrivers.visualstudio.com/ADO.Net/_build/results?buildId=87027&view=results Related work items: #28132
Co-authored-by: Aris Rellegue <[email protected]>
Co-authored-by: Edward Neal <[email protected]>
* Test genapi csproj * remove quote
* Update MS Extensions Hosting package * Update Microsoft.Extensions.Caching.Memory to 6.0.3
Co-authored-by: Cheena Malhotra <[email protected]>
* Replace password with **** * Replace password with **** * Replace password with **** * Replace password with **** * Replace password with ****
- Brought over all relevant 5.1 release notes from main to release/5.1.
* Backport APIScan changes to v5.1 release branch (second attempt with less mistakes) * Add missing NETSTANDARD stuff
There was a problem hiding this comment.
Pull Request Overview
This PR ports the fixes and configuration updates from #3399 into the release/5.1 branch. Key changes include adding new YAML pipeline steps for both .NET Framework and .NET Core test builds, updating jobs for package validation and building signed packages, and minor documentation and build file adjustments.
Reviewed Changes
Copilot reviewed 157 out of 157 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/common/templates/steps/build-and-run-tests-netfx-step.yml | Added YAML pipeline step for running .NET Framework tests. |
| eng/pipelines/common/templates/steps/build-and-run-tests-netcore-step.yml | Added YAML pipeline step for running .NET Core tests. |
| eng/pipelines/common/templates/steps/build-all-configurations-signed-dlls-step.yml | Added YAML pipeline step for building signed DLLs across configurations. |
| eng/pipelines/common/templates/jobs/validate-signed-package-job.yml | Introduced job to validate signed packages with enhanced PowerShell scripts. |
| eng/pipelines/common/templates/jobs/run-tests-package-reference-job.yml | Added job to run tests using a NuGet package reference. |
| eng/pipelines/common/templates/jobs/build-signed-package-job.yml | Added job targeting the build of signed MDS packages. |
| eng/pipelines/common/templates/jobs/build-signed-akv-package-job.yml | Added job targeting the build of signed AKV provider packages. |
| doc/snippets/* & doc/samples/* | Updated sample code and documentation to obfuscate sensitive connection strings. |
| build.proj & NuGet.config | Corrected build command syntax and added audit sources. |
| CHANGELOG.md & BUILDGUIDE.md | Updated release notes and testing documentation. |
| .config/* | Added configuration files for tsa options, policy check exclusions, and credential scan suppressions. |
Comments suppressed due to low confidence (3)
eng/pipelines/common/templates/jobs/validate-signed-package-job.yml:169
- Typo in the output message: 'verfied' should be 'verified'.
Write-Host "`tExpected version verfied in $parentname": $_.Name -ForegroundColor green
eng/pipelines/common/templates/jobs/build-signed-package-job.yml:60
- Parameter name case mismatch: the parameter is defined as 'publishSymbols' but referenced as 'PublishSymbols'. Ensure consistent casing to avoid unexpected behavior.
publishSymbols: ${{ parameters['PublishSymbols'] }}
eng/pipelines/common/templates/jobs/build-signed-akv-package-job.yml:71
- Parameter name case mismatch: the parameter is defined as 'publishSymbols' but is referenced as 'PublishSymbols'. Consider using consistent casing.
publishSymbols: ${{ parameters['PublishSymbols'] }}
| { | ||
| # Run sn.k to verify the strong name on each dll | ||
| $result = & "C:\Program Files (x86)\Microsoft SDKs\Windows\*\bin\NETFX 4.8.1 Tools\sn.exe" -vf $file.FullName | ||
| Write-OutPut $result |
There was a problem hiding this comment.
Typo in PowerShell command: 'Write-OutPut' should be 'Write-Output'.
Suggested change
| Write-OutPut $result | |
| Write-Output $result |
Copilot uses AI. Check for mistakes.
| } | ||
| if($badDlls.Count -gt 0) | ||
| { | ||
| Write-OutPut "Error: Invalid dlls are detected. Chek below list:" |
There was a problem hiding this comment.
Typo in error message: 'Chek' should be 'Check'. Also, 'Write-OutPut' should be corrected to 'Write-Output'.
Suggested change
| Write-OutPut "Error: Invalid dlls are detected. Chek below list:" | |
| Write-Output "Error: Invalid dlls are detected. Check below list:" |
Copilot uses AI. Check for mistakes.
| # Checks the expected folder names such as lib, ref, runtimes | ||
| Get-ChildItem -Path $(extractedNugetPath) -Directory | select Name | foreach { | ||
| if('$(expectedFolderNames)'.contains($_.Name)){ | ||
| Write-Host expected folder name verfied: $_.Name |
There was a problem hiding this comment.
Typo in the output message: 'verfied' should be 'verified'.
Suggested change
| Write-Host expected folder name verfied: $_.Name | |
| Write-Host expected folder name verified: $_.Name |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ports #3399 to release/5.1
Issues
#3397
Testing
The port includes the testcase to validate the fix