Enable vector tests and validate ref assembly for vector APIs #3559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables vector tests against Azure SQLDb instances and adds validation for vector API reference assemblies. The changes focus on making vector functionality testable in Azure environments and ensuring API completeness.
- Enables vector support for Azure SQL Database instances by updating the
IsVectorSupportedflag - Adds
DisableDiscoveryEnumeration = trueto vector test methods to optimize test discovery - Includes a new test case to validate vector API functionality and reference assembly completeness
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| NativeVectorFloat32Tests.cs | Adds DisableDiscoveryEnumeration to test attributes and includes new VectorAPITest method for API validation |
| DataTestUtility.cs | Enables vector support for Azure SQL Database by changing IsVectorSupported logic |
| SqlVector.cs | Fixes XML documentation comment reference path |
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/VectorTest/NativeVectorFloat32Tests.cs
Outdated
Show resolved
Hide resolved
paulmedynski
requested changes
Aug 12, 2025
src/Microsoft.Data.SqlClient/tests/ManualTests/DataCommon/DataTestUtility.cs
Show resolved
Hide resolved
|
@apoorvdeshmukh please port this PR to release/6.1 as well on merge. |
paulmedynski
approved these changes
Aug 12, 2025
|
@paulmedynski @apoorvdeshmukh I think JSON tests enablement will be done separately, and its not covered in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit enable the vector tests against Azure SQLDb Instance add adds testcase to validate ref assembly for vector APIs.
Testing
Vector tests for backward compatibility scenarios and native testcases.
Guidelines
Please review the contribution guidelines before submitting a pull request: