-
Notifications
You must be signed in to change notification settings - Fork 311
Enable vector tests and validate ref assembly for vector APIs #3559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
apoorvdeshmukh
wants to merge
2
commits into
dotnet:main
Choose a base branch
from
apoorvdeshmukh:dev/ad/vectorNullFix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/VectorTest/VectorAPIValidationTest.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using System; | ||
| using Microsoft.Data.SqlTypes; | ||
| using Xunit; | ||
|
|
||
| namespace Microsoft.Data.SqlClient.ManualTesting.Tests.SQL.VectorTest | ||
| { | ||
| public sealed class VectorAPIValidationTest | ||
| { | ||
| // We need this testcase to validate ref assembly for vector APIs | ||
| // Unit tests are covered under SqlVectorTest.cs | ||
| [Fact] | ||
| public void VectorAPITest() | ||
| { | ||
| // Validate that SqlVector<float> is a valid type and has valid SqlDbType | ||
| Assert.True(typeof(SqlVector<float>).IsValueType, "SqlVector<float> should be a value type."); | ||
| Assert.Equal(36, (int)SqlDbTypeExtensions.Vector); | ||
|
|
||
| // Validate ctor1 with float[] : public SqlVector(System.ReadOnlyMemory<T> memory) { } | ||
| var vector = new SqlVector<float>(VectorFloat32TestData.testData); | ||
| Assert.Equal(VectorFloat32TestData.testData, vector.Memory.ToArray()); | ||
| Assert.Equal(3, vector.Length); | ||
|
|
||
| // Validate ctor2 with ReadOnlyMemory<T> : public SqlVector(ReadOnlyMemory<T> memory) { } | ||
| vector = new SqlVector<float>(new ReadOnlyMemory<float>(VectorFloat32TestData.testData)); | ||
| Assert.Equal(VectorFloat32TestData.testData, vector.Memory.ToArray()); | ||
| Assert.Equal(3, vector.Length); | ||
|
|
||
| //Validate IsNull property | ||
| Assert.False(vector.IsNull, "IsNull should be false for non-null vector."); | ||
|
|
||
| // Validate Null property returns null | ||
| Assert.Null(SqlVector<float>.Null); | ||
|
|
||
| //Validate length property | ||
| Assert.Equal(3, vector.Length); | ||
|
|
||
| // Validate CreateNull method | ||
| vector = SqlVector<float>.CreateNull(5); | ||
| Assert.True(vector.IsNull); | ||
| Assert.Equal(5, vector.Length); | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.