feat: disable error logging stacktrace in message

[CorieW]

Resolves #1681

[Copilot]

Pull Request Overview

Adds a new global option to disable automatic inclusion of error stacktraces in logs and updates the logger and tests to respect this setting.

• Introduce disableErrorLoggingTraceback in GlobalOptions
• Modify entryFromArgs to skip stacktrace when the option is enabled
• Add tests for default stacktrace inclusion and disabling behavior

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/v2/options.ts	Add disableErrorLoggingTraceback to GlobalOptions with accompanying JSDoc
src/logger/index.ts	Check getGlobalOptions().disableErrorLoggingTraceback before injecting stacktrace
spec/logger.spec.ts	Tests for error logging behavior with and without the new option

Comments suppressed due to low confidence (2)

src/v2/options.ts:241

• Fix the JSDoc wording to remove the double negative, e.g. When true, the error message will not include the traceback of the error.

* When true, the error message will include not include the traceback of the error.

spec/logger.spec.ts:223

• Consider adding a test case where logger.error is called with an actual Error object to ensure that existing Error instances aren’t wrapped with a new stacktrace.

describe("error logging stacktrace", () => {

[cabljac]

Some minor changes/comments

[cabljac]

I would use "stacktrace" instead of "traceback" as afaik traceback is mostly a python term?

[cabljac]

disableErrorStackTrace or suppressErrorStack or something?

[CorieW]

Just went with disableErrorLoggingStacktrace, since it refers to logging. I feel like disableErrorStacktrace isn't clear enough.

disableErrorLogStacktrace could be an alternative?

[cabljac]

ya disableErrorLoggingStacktrace sounds good!

[cabljac]

lgtm

[taeold]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a new global option disableErrorLoggingStacktrace to control the automatic inclusion of stack traces in error logs. The implementation logic in the logger and the option definition are generally sound, but there are opportunities to improve test quality, code readability, and the default value of the new option.

[gemini-code-assist]

The use of setGlobalOptions within beforeEach and afterEach can lead to repeated calls to this function, potentially resulting in noisy test logs. Consider introducing a test-only helper function in src/v2/options.ts to reset the internal globalOptions variable to avoid this warning.

[gemini-code-assist]

The default value for disableErrorLoggingStacktrace is set to false. It would be more intuitive if the default was true, aligning with the description that states 'When true, the error message will not include the stacktrace'.

Suggested change

	* Defaults to false.
	*
	* Defaults to true.