Add dql_strict_mode=false to all quickstarts #88
Conversation
okdistribute
requested review from
phatblat,
konstantinbe,
kristopherjohnson,
cameron1024,
teodorciuraru,
pvditto,
busec0,
anyercastillo and
a team
as code owners
flutter_app/lib/main.dart
Outdated
| _ditto!.store.execute("ALTER SYSTEM SET DQL_STRICT_MODE = false").then((_) { | ||
| setState(() => _ditto!.startSync()); | ||
| }); |
There was a problem hiding this comment.
This needs to be set whenever sync is stopped and started again?
There was a problem hiding this comment.
No, I don't think so.
There was a problem hiding this comment.
AI Slop trying to do it's best because I said "set this before startSync is called"
| @@ -313,6 +313,7 @@ private void StartSync() | |||
| { | |||
| try | |||
| { | |||
| ditto.Store.Execute("ALTER SYSTEM SET DQL_STRICT_MODE = false"); | |||
There was a problem hiding this comment.
This is an async method that would need to be awaited. And the name is ExecuteAsync
| @@ -250,6 +250,7 @@ public DittoStoreObserver ObserveTasksCollection(Func<IList<ToDoTask>, Task> han | |||
| /// </summary> | |||
| public void StartSync() | |||
| { | |||
| ditto.Store.Execute("ALTER SYSTEM SET DQL_STRICT_MODE = false"); | |||
There was a problem hiding this comment.
This is an async method that would need to be awaited. And the name is ExecuteAsync
| @@ -246,6 +246,7 @@ public DittoStoreObserver ObserveTasksCollection(Func<IList<ToDoTask?>, Task> ha | |||
| /// </summary> | |||
| public void StartSync() | |||
| { | |||
| ditto.Store.Execute("ALTER SYSTEM SET DQL_STRICT_MODE = false"); | |||
There was a problem hiding this comment.
This is an async method that would need to be awaited. And the name is ExecuteAsync
swift/Tasks/TasksListScreen.swift
Outdated
| Task { | ||
| try await dittoStore.execute(query: "ALTER SYSTEM SET DQL_STRICT_MODE = false") | ||
| } |
There was a problem hiding this comment.
Taken a closer look: I suspect the intention here is to bubble up any error happening within the Task scope to the caller of startSync(). Correct?
Task is performed asynchronously and errors are swallowed, i.e. go unnoticed. So if the query fails for some reason, sync will still be started and no error will be presented or anything.
If my assumption is correct, then you'd have to rewrite the code path and make it account for async execution and error handling.
There was a problem hiding this comment.
Adding await requires this to be async?
There was a problem hiding this comment.
Can you help me with this one? I don't fully understand Swift async (and I know it's a sore spot in our SDK)
There was a problem hiding this comment.
Sure. Is there a reason why this is executed as part of start sync button? It looks like it needs to be executed once, ideally at initialization time. Here is the simplest solution: #91. Adding proper error handling would require another 1 - 2 pages of SwiftUI code and would need to be ported to all the others — not worth it.
There was a problem hiding this comment.
Reason only being AI slop ;)
There was a problem hiding this comment.
I don't think that counts as an excuse tbh.
There was a problem hiding this comment.
Not an excuse, just a reality of time constraints. I can close the PR and prefer others to finish this out
Fixes MAR-132