Skip to content

Move ALTER SYSTEM call outside of startSync() into a view task #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Move ALTER SYSTEM call outside of startSync() into a view task #91

wants to merge 6 commits into from

Conversation

konstantinbe
Copy link
Contributor

@konstantinbe konstantinbe commented Jul 16, 2025 •
edited
Loading

Review feedback for #88:

  • Executes the ALTER SYSTEM query once in an async task
  • Panics (fatalError()) if the query execution fails (query is static and should always succeed, error expected only in exceptional cases, hence the panic)

@konstantinbe konstantinbe mentioned this pull request Jul 16, 2025
Closed
@okdistribute okdistribute changed the base branch from rae/strict-mode to main July 16, 2025 20:17
@okdistribute okdistribute changed the base branch from main to rae/strict-mode July 16, 2025 20:17
@okdistribute
Copy link
Contributor

I cancelled my PR, I should have labeled it as a draft, feel free to merge into main directly

@konstantinbe konstantinbe changed the base branch from rae/strict-mode to main July 25, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okdistribute okdistribute Awaiting requested review from okdistribute

@phatblat phatblat Awaiting requested review from phatblat phatblat will be requested when the pull request is marked ready for review phatblat is a code owner

@busec0 busec0 Awaiting requested review from busec0 busec0 will be requested when the pull request is marked ready for review busec0 is a code owner

@kristopherjohnson kristopherjohnson Awaiting requested review from kristopherjohnson kristopherjohnson will be requested when the pull request is marked ready for review kristopherjohnson is a code owner

@cameron1024 cameron1024 Awaiting requested review from cameron1024 cameron1024 will be requested when the pull request is marked ready for review cameron1024 is a code owner

@teodorciuraru teodorciuraru Awaiting requested review from teodorciuraru teodorciuraru will be requested when the pull request is marked ready for review teodorciuraru is a code owner

@pvditto pvditto Awaiting requested review from pvditto pvditto will be requested when the pull request is marked ready for review pvditto is a code owner

@anyercastillo anyercastillo Awaiting requested review from anyercastillo anyercastillo will be requested when the pull request is marked ready for review anyercastillo is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@konstantinbe @okdistribute