Skip to content

C++: Cache DefaultTaintTracking #2864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2020
Merged

C++: Cache DefaultTaintTracking #2864

merged 1 commit into from
Feb 25, 2020

Conversation

jbj
Copy link
Contributor

@jbj jbj commented Feb 18, 2020

This should speed up the overall suite, where DefaultTaintTracking is used in several queries.

@jbj jbj added the C++ label Feb 18, 2020
@jbj
Copy link
Contributor Author

jbj commented Feb 18, 2020

To do:

@jbj
C++: Cache DefaultTaintTracking
ae68878 
This should speed up the overall suite, where `DefaultTaintTracking` is
used in several queries.
@jbj jbj force-pushed the DefaultTaintTracking-cached branch from e104136 to ae68878 Compare February 24, 2020 12:03
@jbj
Copy link
Contributor Author

jbj commented Feb 24, 2020 •
edited
Loading

Testing at https://jenkins.internal.semmle.com/job/Changes/job/CPP-Differences/853/

@jbj
Copy link
Contributor Author

jbj commented Feb 25, 2020

time_split_absolute

This change seems to be an overall slight improvement for analysis time.

@jbj jbj marked this pull request as ready for review February 25, 2020 07:02
@jbj jbj requested a review from a team as a code owner February 25, 2020 07:02
@jbj
Copy link
Contributor Author

jbj commented Feb 25, 2020

I've looked at ChakraCore's performance changes in the profile viewer, and the slight slowdown seems to be unrelated to this PR. It affects all the stages that have nothing to do with the caching of DefaultTaintTracking, so I'll write it off as unrelated performance fluctuations of the Jenkins worker.

MathiasVP
MathiasVP approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MathiasVP MathiasVP merged commit b9bb2ec into github:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathiasVP MathiasVP MathiasVP approved these changes

Assignees
No one assigned
Labels
C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbj @MathiasVP