Skip to content

C++: Use IR for security.TaintTracking and GVN #2851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 18, 2020

Conversation

jbj
Copy link
Contributor

@jbj jbj commented Feb 15, 2020

Only merge this if https://git.semmle.com/Semmle/code/pull/36239 can be merged immediately after.

This is the big one! When this is merged, the IR will be in production.

@jbj jbj added the C++ label Feb 15, 2020
jbj and others added 3 commits February 15, 2020 21:10
Without this, the test will compare the IR to itself after we enable it.
This is for the tests in the ql repo. There are also changed tests in
the internal repo.
@jbj jbj added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Feb 15, 2020
The language tests were failing because they don't tolerate mentioning a
deprecated class anywhere.
@jbj jbj marked this pull request as ready for review February 18, 2020 09:41
@jbj jbj requested a review from a team as a code owner February 18, 2020 09:41
Copy link
Contributor

@rdmarsh2 rdmarsh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Failing tests are fixed by internal PR 36239.

Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rdmarsh2 rdmarsh2 merged commit aaf6926 into github:master Feb 18, 2020
MathiasVP added a commit to MathiasVP/ql that referenced this pull request Aug 2, 2025
MathiasVP added a commit to MathiasVP/ql that referenced this pull request Aug 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants