Bounds and project tidying #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneira
approved these changes
Dec 15, 2021
| @@ -99,7 +99,7 @@ test-suite func-test | |||
| main-is: FuncTest.hs | |||
| hs-source-dirs: func-test | |||
| type: exitcode-stdio-1.0 | |||
| build-depends: base <4.16 | |||
| build-depends: base | |||
There was a problem hiding this comment.
should not have the package base bounds?
There was a problem hiding this comment.
It depends on lsp-test which has the bounds - adding them here just means extra work IMO.
There was a problem hiding this comment.
oh I missed the existing bound in the package lib 👍
.github/workflows/haskell.yml
Outdated
| @@ -20,7 +20,7 @@ jobs: | |||
| - uses: haskell/actions/setup@v1 | |||
| with: | |||
| ghc-version: ${{ matrix.ghc }} | |||
| cabal-version: '3.4' | |||
| cabal-version: 'latest' | |||
There was a problem hiding this comment.
not always last cabal is good, would 3.6 be too much careful?
There was a problem hiding this comment.
afaik 3.6 will pick 3.6.2.0, 3.6.0.0 suffered some bugs
Also delete bounds on components other than the main library component, they don't do anything.
michaelpj
force-pushed
the
mpj/tidy-bounds
branch
from
0249e0f to
029be8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out of #377